TokenManager storage options #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftone
approved these changes
Nov 8, 2019
swiftone
reviewed
Nov 8, 2019
| @@ -20,7 +20,8 @@ function setupSync(options) { | |||
| redirectUri: 'https://example.com/redirect', | |||
| tokenManager: { | |||
| expireEarlySeconds: options.tokenManager.expireEarlySeconds || 0, | |||
| storage: options.tokenManager.type, | |||
| storage: options.tokenManager.storage, | |||
There was a problem hiding this comment.
💯 to this change - having the tests match the naming is one of those subtle things that pays off so much down the line.
swiftone
approved these changes
Nov 8, 2019
|
I just found this solution in the README for master branch and implemented it in my client before realizing the new version hadn't been released. Can we get a |
|
@hboylan We are planning to publish this week. I will update with another comment when it is published. |
|
@hboylan New version (2.10.0) has been published. Hopefully everything works as expected for you! If you see any issues, please open a new issue. Thanks for using our SDK. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenManager.storageKeyRelated GH issues:
#207
#215
#211