Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "onSessionExpired" option #271

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Add "onSessionExpired" option #271

merged 2 commits into from
Jan 9, 2020

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Nov 13, 2019 •
edited
Loading

  • top-level sdk instance will listen to error events from token manager:
  • error handling for "login_required" error with accessToken will call method onSessionExpired if passed in options

@aarongranick-okta aarongranick-okta force-pushed the ag-auth-required-OKTA-259073 branch from 40ba44d to 8e58060 Compare November 13, 2019 19:43
swiftone
swiftone reviewed Nov 18, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@swiftone
Copy link
Contributor

Relevant: #287

@aarongranick-okta
Copy link
Contributor Author

okta/samples-js-react#37

@aarongranick-okta
Copy link
Contributor Author

okta/okta-oidc-js#227

@aarongranick-okta aarongranick-okta force-pushed the ag-auth-required-OKTA-259073 branch from 5007092 to 7325c01 Compare January 8, 2020 20:40
@aarongranick-okta aarongranick-okta force-pushed the ag-auth-required-OKTA-259073 branch from 7325c01 to 1a452fc Compare January 8, 2020 21:54
@aarongranick-okta aarongranick-okta changed the title Emit events from token manager. Add "onSessionEnd" option Add "onSessionExpired" option Jan 8, 2020
@swiftone swiftone self-requested a review January 9, 2020 16:46
@aarongranick-okta aarongranick-okta merged commit 6774a8e into master Jan 9, 2020
@aarongranick-okta aarongranick-okta deleted the ag-auth-required-OKTA-259073 branch January 9, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftone swiftone swiftone approved these changes

@robertjd robertjd Awaiting requested review from robertjd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarongranick-okta @swiftone