feat: parseFromUrl return tokens in hash, also include state #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongranick-okta
force-pushed
the
v3.0
branch
2 times, most recently
from
efd2259 to
28a83f5
Compare
aarongranick-okta
force-pushed
the
ag-tokens-format-OKTA-106993
branch
from
8559af4 to
474441f
Compare
swiftone
reviewed
Jan 22, 2020
| @@ -1616,8 +1628,15 @@ The ID token will be [verified and validated](https://github.com/okta/okta-auth- | |||
|
|
|||
| ```javascript | |||
| authClient.token.parseFromUrl() | |||
| .then(function(tokenOrTokens) { | |||
| .then(function(res) { | |||
There was a problem hiding this comment.
res implies an HTTP Response object, is there a better name?
There was a problem hiding this comment.
It is an object which contains a tokens hash and a state string.
swiftone
reviewed
Jan 22, 2020
| @@ -266,32 +272,28 @@ function handleOAuthResponse(sdk, oauthParams, res, urls) { | |||
|
|
|||
| return verifyToken(sdk, idToken, validationParams) | |||
| .then(function() { | |||
| tokenDict['id_token'] = idToken; | |||
| tokenDict['idToken'] = idToken; | |||
There was a problem hiding this comment.
nit: why not dot notation?
swiftone
reviewed
Jan 22, 2020
Comment on lines
+239
to
242
| value: res['access_token'], | ||
| accessToken: res['access_token'], | ||
| expiresAt: Number(res['expires_in']) + Math.floor(Date.now()/1000), | ||
| tokenType: res['token_type'], |
There was a problem hiding this comment.
nit: why not dot notation for all of these? (underscore isn't a problem, just '-')
swiftone
reviewed
Jan 22, 2020
swiftone
approved these changes
Jan 22, 2020
aarongranick-okta
force-pushed
the
ag-tokens-format-OKTA-106993
branch
from
474441f to
9288398
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes behavior on
parseFromUrlPreviously:
responseTypesresponseTypeswas not an array, the token object was returnedNow:
statewhich contains the value passed togetWithRedirect(or any of the othergetTokencalls) This allows passing information to the callback handler.tokenswhich contains a hash of tokens returned. Possible key values areidTokenandaccessTokenvaluewhich contains the raw token string. For an ID token this is the same as theidTokenfield, for an access token it is the same as theaccessTokenfield.