feat: support responseMode=query for PKCE flow #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftone
reviewed
Jan 28, 2020
README.md
Outdated
| @@ -197,6 +197,7 @@ tokenManager: { | |||
| | `redirectUri` | The url that is redirected to when using `token.getWithRedirect`. This must be pre-registered as part of client registration. If no `redirectUri` is provided, defaults to the current origin. | | |||
| | `postLogoutRedirectUri` | Specify the url where the browser should be redirected after [signOut](#signout). This url must be added to the list of `Logout redirect URIs` on the application's `General Settings` tab. | |||
| | `pkce` | If set to true, the authorization flow will automatically use PKCE. The authorize request will use `response_type=code`, and `grant_type=authorization_code` will be used on the token request. All these details are handled for you, including the creation and verification of code verifiers. | | |||
| | `responseMode` | Applicable only for SPA clients using PKCE flow. By default, when requesting tokens via redirect (Initiated with `token.getWithRedirect` and handled using `token.parseFromUrl`), token values are requested and parsed from the hash fragment. Setting this value to `query` will use the URL search query instead. | | |||
There was a problem hiding this comment.
Might we want to say WHEN they want to do this?
e.g.
"If your application makes use/alters the hash fragment of the url, you may want to set to this parameter to 'query'."
swiftone
reviewed
Jan 28, 2020
CHANGELOG.md
Outdated
|
|
||
| ### Features | ||
|
|
||
| - [#324](https://github.com/okta/okta-auth-js/pull/324) - Support `responseMode: "query"` for SPA apps using PKCE flow |
There was a problem hiding this comment.
Perhaps?:
Support responseMode: "query" option for SPA apps using PKCE flow"
aarongranick-okta
force-pushed
the
ag-responsemode-query-OKTA-269833
branch
from
ba2077f to
d57feec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
responseMode="query"if using PKCE flow (server returns an unsupported response mode error if using implicit flow)getWithRedirectandparseFromUrl