feat: responseMode uses openid defaults #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarongranick-okta
commented
Jan 30, 2020
aarongranick-okta
commented
- responseMode will not be passed to authorize endpoint unless explicitly specified
- default responseMode for PKCE is "query"
swiftone
reviewed
Jan 30, 2020
packages/okta-auth-js/lib/token.js
Outdated
Comment on lines
745
to
750
|
|
||
| if (!responseMode) { | ||
| // By default Authentication Code flow uses "query", Implicit flow uses "fragment" | ||
| // https://openid.net/specs/openid-connect-core-1_0.html#Authentication | ||
| responseMode = sdk.options.pkce ? 'query' : 'fragment'; | ||
| } |
There was a problem hiding this comment.
nit: Before defining responseMode, you could define defaultResponseMode:
// By default Authentication Code flow uses "query", Implicit flow uses "fragment"
// https://openid.net/specs/openid-connect-core-1_0.html#Authentication
var defaultResponseMode = sdk.options.pkce ? 'query' : 'fragment';
var responseMode = options.responseMode || sdk.options.responseMode || defaultResponseMode;
Arguably this manages the focus a bit better.
swiftone
approved these changes
Jan 30, 2020
aarongranick-okta
force-pushed
the
ag-oidc-defaults-OKTA-243439
branch
from
a489134 to
6a32ce7
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.