feat: lock expireEarlySeconds for non-dev env - OKTA-342102 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev-5.0 #540 +/- ##
==========================================
Coverage ? 91.27%
==========================================
Files ? 32
Lines ? 1845
Branches ? 411
==========================================
Hits ? 1684
Misses ? 161
Partials ? 0 Continue to review full report at Codecov.
|
swiftone
reviewed
Nov 9, 2020
| @@ -434,6 +435,10 @@ export class TokenManager { | |||
| options._storageEventDelay = options._storageEventDelay || 1000; | |||
| } | |||
|
|
|||
| if (!isLocalhost()) { | |||
| options.expireEarlySeconds = DEFAULT_OPTIONS.expireEarlySeconds; | |||
There was a problem hiding this comment.
We should mention this in the README as well, otherwise they'll get no feedback on why their setting is being ignored
aarongranick-okta
approved these changes
Nov 10, 2020
aarongranick-okta
pushed a commit
that referenced
this pull request
Mar 10, 2021
aarongranick-okta
pushed a commit
that referenced
this pull request
Apr 2, 2021
aarongranick-okta
pushed a commit
that referenced
this pull request
Apr 14, 2021
aarongranick-okta
pushed a commit
that referenced
this pull request
Apr 20, 2021
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Apr 20, 2021
OKTA-388545 <<<Jenkins Check-In of Tested SHA: 6842f2a for [email protected]>>> Artifact: okta-auth-js Files changed count: 252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.