add support for interaction_code on redirect callback #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils to detect interaction_required error
aarongranick-okta
force-pushed
the
ag-OKTA-363769-redirect-interaction-code
branch
from
fcf0323 to
87a405b
Compare
swiftone
reviewed
Feb 9, 2021
| return options.pkce || options.responseType === 'code' || options.responseMode === 'query'; | ||
| } | ||
|
|
||
| export function getHashOrSearch(options: OktaAuthOptions) { |
There was a problem hiding this comment.
nit: getSearchOrHash()? (which does it default to?)
There was a problem hiding this comment.
The default depends on your configured responseType and pkce setting. implicit is hash, authorization code is query.
swiftone
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils to detect interaction_required error
Also refactors tests from the former
oauthUtilfile and adds more tests related to login redirect handling.