feat: check if flow is supported - OKTA-406094 #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
force-pushed
the
sw-check-if-flow-is-supported-406094
branch
from
a88175c to
cb98997
Compare
aarongranick-okta
approved these changes
Jun 28, 2021
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jun 28, 2021
feat: detect if passowrd recovery flow is supported - OKTA-406094 add unit test lint & changelog fix npm issue in sample folders OKTA-406094 <<<Jenkins Check-In of Tested SHA: cb98997 for [email protected]>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#838"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
When using
idx.recoverPasswordmethod, tokens might be returned without ask the user to reset the password (basically just authentication flow has been executed), this behaviour confuses devs.Solution:
Check if the key remediation (reset-authenticator) is proceeded before exchanging code for tokens. AuthSDKError is thrown if the key remediation is not called.