Add response headers to all responses #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
+ Coverage 91.97% 91.98% +0.01%
==========================================
Files 120 120
Lines 3400 3405 +5
Branches 699 700 +1
==========================================
+ Hits 3127 3132 +5
Misses 273 273
Continue to review full report at Codecov.
|
shuowu
reviewed
Sep 8, 2021
lib/fetch/fetchRequest.ts
Outdated
| const result: HttpResponse = { | ||
| responseText: isObject ? JSON.stringify(data) : data as string, | ||
| status: status | ||
| status: status, | ||
| responseHeaders |
There was a problem hiding this comment.
how about name it as headers?
denysoblohin-okta
force-pushed
the
od-OKTA-412511-RAWRESPONSE
branch
from
dca6b15 to
f805edf
Compare
denysoblohin-okta
changed the title
shuowu
approved these changes
Sep 10, 2021
denysoblohin-okta
force-pushed
the
od-OKTA-412511-RAWRESPONSE
branch
from
f805edf to
4bedbf2
Compare
denysoblohin-okta
force-pushed
the
od-OKTA-412511-RAWRESPONSE
branch
from
4bedbf2 to
a0e5b10
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Sep 13, 2021
OKTA-412511 <<<Jenkins Check-In of Tested SHA: a0e5b10 for [email protected]>>> Artifact: okta-auth-js Files changed count: 15 PR Link: "#932"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose request headers in new
responseHeadersproperty. Value is object filled with response headers key-value pairs.This can be useful to get X-Rate-Limit-* headers as requested in #230
Another solution could be exposing the whole
Responseobject instead (eg. in propertyrawResponse, then headers could be accessed withHeadersAPI).But that approach leads to problems with unit testing and caching responses (complications with serialization and mocking
Fetch APIobjects).Internal ref: OKTA-412511
Resolves #230
Important
Most headers are not accessible in browsers due to CORS. (In Node environment it works fine)
Access-Control-Expose-Headersshould be set from server-side to allow web clients to useX-Rate-Limit-*etc. headers