fix ambiguous error codes

okta · Dec 21, 2021 · 7319931 · 7319931
1 parent 6e0596b
commit 7319931
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 5 deletions.
diff --git a/library/src/main/java/com/okta/oidc/net/HttpResponse.java b/library/src/main/java/com/okta/oidc/net/HttpResponse.java
@@ -18,6 +18,9 @@
 import androidx.annotation.Nullable;
 import androidx.annotation.RestrictTo;
 
+import com.okta.oidc.util.AuthorizationException;
+import com.okta.oidc.util.UriUtil;
+
 import org.json.JSONException;
 import org.json.JSONObject;
 
@@ -111,11 +114,28 @@ public JSONObject asJson() throws IOException, JSONException {
                 mStatusCode >= HttpURLConnection.HTTP_MULT_CHOICE) {
             throw new HttpStatusCodeException(mStatusCode, mHttpClient.getResponseMessage());
         }
-        InputStream is = getContent();
-        if (is == null) {
+        return getJsonObjectFromResponseInputStream(getContent());
+    }
+
+    public JSONObject asJsonWithErrorDescription() throws IOException, JSONException {
+        if (mStatusCode < HttpURLConnection.HTTP_OK ||
+                mStatusCode >= HttpURLConnection.HTTP_MULT_CHOICE) {
+            try {
+                return getJsonObjectFromResponseInputStream(getContent());
+            } catch (Exception any) {
+                throw new HttpStatusCodeException(mStatusCode, mHttpClient.getResponseMessage());
+            }
+        }
+        return getJsonObjectFromResponseInputStream(getContent());
+    }
+
+    private static JSONObject getJsonObjectFromResponseInputStream(
+            final InputStream inputStream
+    ) throws IOException, JSONException {
+        if (inputStream == null) {
             throw new IOException("Input stream must not be null");
         }
-        BufferedReader reader = new BufferedReader(new InputStreamReader(is));
+        BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
         Writer writer = new StringWriter();
         String line = reader.readLine();
         while (line != null) {

diff --git a/library/src/main/java/com/okta/oidc/net/request/TokenRequest.java b/library/src/main/java/com/okta/oidc/net/request/TokenRequest.java
@@ -128,7 +128,7 @@ public TokenResponse executeRequest(OktaHttpClient client) throws AuthorizationE
         TokenResponse tokenResponse;
         try {
             response = openConnection(client);
-            JSONObject json = response.asJson();
+            JSONObject json = response.asJsonWithErrorDescription();
             if (json.has(AuthorizationException.PARAM_ERROR)) {
                 try {
                     final String error = json.getString(AuthorizationException.PARAM_ERROR);

diff --git a/library/src/main/java/com/okta/oidc/net/response/TokenResponse.java b/library/src/main/java/com/okta/oidc/net/response/TokenResponse.java
@@ -61,6 +61,10 @@ public String getRefreshToken() {
         return refresh_token;
     }
 
+    public void setRefreshToken() {
+        refresh_token = "fljsdhgfjkhsafjk";
+    }
+
     public String getIdToken() {
         return id_token;
     }

diff --git a/library/src/test/java/com/okta/oidc/clients/sessions/SessionClientImplTest.java b/library/src/test/java/com/okta/oidc/clients/sessions/SessionClientImplTest.java
@@ -232,7 +232,7 @@ public void refreshTokenFailure() throws InterruptedException {
         latch.await();
         assertNull(cb.getResult());
         assertNotNull(cb.getException());
-        assertEquals(cb.getException().getMessage(), "Invalid status code 401 Client Error");
+        assertEquals(cb.getException().getMessage(), "No client credentials found.");
     }
 
     @Test