Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes androidx lifecycle compliance #230

Closed
wants to merge 2 commits into from
Closed

Fixes androidx lifecycle compliance #230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecfd9d5
Fixes androidx lifecycle compliance
NikitaAvraimov-okta Apr 2, 2021
5cc2379
Merge branch 'master' into na-OKTA-383062-fix-lifecycle-registry-thre…
NikitaAvraimov-okta Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions library/src/main/java/com/okta/oidc/clients/web/SyncWebAuthClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,12 @@ private StateResult startSignIn(Activity activity, WebRequest request)
CountDownLatch latch = new CountDownLatch(1);

if (activity instanceof FragmentActivity) {
addLoginFragment(request, mCustomTabOptions, (FragmentActivity) activity,
mSupportedBrowsers);
activity.runOnUiThread(() -> addLoginFragment(
request,
mCustomTabOptions,
(FragmentActivity) activity,
mSupportedBrowsers
));
} else {
Intent intent = createAuthIntent(activity, request.toUri(), mCustomTabOptions,
mSupportedBrowsers);
Expand Down Expand Up @@ -314,8 +318,12 @@ private StateResult startSignOut(Activity activity, WebRequest request)
CountDownLatch latch = new CountDownLatch(1);
AtomicReference<StateResult> resultWrapper = new AtomicReference<>();
if (activity instanceof FragmentActivity) {
addLogoutFragment(request, mCustomTabOptions, (FragmentActivity) activity,
mSupportedBrowsers);
activity.runOnUiThread(() -> addLogoutFragment(
request,
mCustomTabOptions,
(FragmentActivity) activity,
mSupportedBrowsers
));
} else {
Intent intent = createAuthIntent(activity, request.toUri(),
mCustomTabOptions, mSupportedBrowsers);
Expand Down