Fix for ActivityNotFoundException (closes #166) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidvavra Thanks for the PR. This looks ok to me. But I'll double check with @NikitaAvraimov-okta and @FeiChen-okta before pulling it in. Could you also sign our CLA? https://developer.okta.com/cla/ |
JayNewstrom
reviewed
Oct 25, 2021
library/src/main/java/com/okta/oidc/OktaAuthenticationActivity.java
Outdated
Show resolved
Hide resolved
JayNewstrom
approved these changes
Oct 26, 2021
|
Thanks, I just sent signed CLA to [email protected] |
|
@JayNewstrom Can you share plans for a new release containing this fix? |
|
@davidvavra I'll prepare the release and ship it today. Should be live in 2-3 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have a lot of crashes with this exception in production. I'm not sure about a root cause, but it's better to display a meaningful message to the user (browser not found) than to crash the app.