fix: Move react-router-dom as an explicit dependency
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `react-router-dom` is not always required at runtime (only really requested when using `<SecureRoute />`), having it defined as a peer dependency raise issues for any user wanted to move to next majors of `react-router-dom` and not relying on `<SecureRoute />`. Indeed for such users of `okta-react`, WebPack and other bundlers will fail to build the project because of the import of `useMatchRoute` not being part of the new major of `react-router-dom`. While it probably make a bit of sense whne you use `<SecureRoute />`, having your build broken because of it while you don't need it at all is strange. By moving the library as a clear dependency, `okta-react` wil always pull the right version and stop making user's builds fail.
dubzzz
force-pushed
the
move-react-router-dom-as-dep
branch
from
652cb4a to
ca91f0c
Compare
dubzzz
changed the title
react-router-dom as an explicit dependencyreact-router-dom as an explicit dependency
|
These packages need to be peer dependencies because the same version needs to be used in our sdk as in the application. This is the same reason However we are currently re-evaluating |
|
Closing following comment #178 (comment) It seems that there is something under way to unlock the situation. |
|
@jaredperreault-okta So far I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
react-router-domis not always required at runtime (only really requested when using<SecureRoute />), having it defined as a peer dependency raises issues for any user wanted to move to next majors ofreact-router-domand not relying on<SecureRoute />.Indeed for such users of
okta-react, WebPack and other bundlers will fail to build the project because of the import ofuseMatchRoutenot being part of the new major ofreact-router-dom. While it probably makes a bit of sense when you use<SecureRoute />, having your build broken because of it while you don't need it at all is strange. By moving the library as a clear dependency,okta-reactwill always pull the right version and stop making user's builds fail.Suggestion for #178
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers