Typescript definitions for operations #224
Merged
+980
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romise<undefined>
oleksandrpravosudko-okta
force-pushed
the
op-okta-291118-operations-typescript-definitions
branch
from
59c916f to
cb3980a
Compare
swiftone
reviewed
Feb 18, 2021
templates/helpers/operation.js
Outdated
| const getBodyModelNameInCamelCase = operation => { | ||
| const MODELS_SHOULD_NOT_PROCESS = ['object', 'string', 'undefined']; | ||
|
|
||
| // BEGIN work around spec mismatches and upstream parsing incosistencies |
There was a problem hiding this comment.
nit: should be "inconsistencies", though I appreciate the irony
swiftone
reviewed
Feb 18, 2021
templates/helpers/operation.js
Outdated
| } | ||
| } | ||
| return typedArgs.join(', '); | ||
| } |
There was a problem hiding this comment.
nit: missing semicolon
Several of the const below as well
swiftone
reviewed
Feb 18, 2021
| const MODELS_SHOULD_NOT_PROCESS = ['object', 'string', 'undefined']; | ||
|
|
||
| // BEGIN work around spec mismatches and upstream parsing incosistencies | ||
| const RESTRICTED_MODEL_PROPERTY_OVERRIDES = { |
There was a problem hiding this comment.
This is good work dealing with the exceptions, but I'm worried the next person to touch this may not follow, particularly since the templates say to set the property UNLESS it is an override (the opposite of what I'd expect an override to do).
Could you drop in a 1-2 line comment clarifying the logic here?
There was a problem hiding this comment.
Sure - I was hoping that could be read as 'add a property unless it's an illegal override', but that didn't work out so well 😅
aarongranick-okta
approved these changes
Feb 19, 2021
oleksandrpravosudko-okta
deleted the
op-okta-291118-operations-typescript-definitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated model types are extracted to a separate branch: #225
TS lint setup is to follow in a subsequent PR.
Resolves: OKTA-291118