Fine tune configuration for ArgoCD ignore #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nacho Fuertes <[email protected]>
ifbyol
requested review from
codyjlandstrom,
pchico83 and
rlamana
as code owners
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nacho Fuertes <[email protected]>
pchico83
approved these changes
Feb 19, 2025
Signed-off-by: Nacho Fuertes <[email protected]>
codyjlandstrom
approved these changes
Feb 19, 2025
|
@ifbyol Cool if I add these to the current docs version as well? |
@codyjlandstrom It is already added to the current version, isn't it? It is in the default folder, but also in |
You I right.... I just can't read 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a rule to ignore some fields in the
okteto-botservice account created as part of the installation, and also improved the current rule for the mutatingwebhookconfiguration, as we had to manually add more lines if we include more webhooks on it. I also took the chance to create specific rules for validating and mutating webhooks (previous rule wasn't specifying the kind, so it was considering everything under the groupadmissionregistration.k8s.io.I was testing it on an ArgoCD instance I deployed for testing purposes