Jlo/fix-relay-restarts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Lopez <[email protected]>
Signed-off-by: Javier Lopez <[email protected]>
| supervisor: | ||
| context: . | ||
| image: ${REGISTRY_AND_USER:-okteto}/supervisor:${VERSION:-latest} |
There was a problem hiding this comment.
what do you think if we use some more conventional env vars?
If we use OKTETO_NAMESPACE instead of USER it's replaced out of the box. For the Registry, unfortunatelty it's only injected in the deploy steps, but still we could have a comment as example.
Suggested change
| image: ${REGISTRY_AND_USER:-okteto}/supervisor:${VERSION:-latest} | |
| image: ${OKTETO_REGISTRY_URL}/${OKTETO_NAMESPACE}/supervisor:${VERSION:-latest} | |
| # Example: OKTETO_REGISTRY_URL=registry.product.okteto.dev okteto build` |
There was a problem hiding this comment.
With that approach it's difficult to know that you can push to other registries rather than the okteto one, like docker hub.
Signed-off-by: Javier Lopez <[email protected]>
andreafalzetti
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier Lopez [email protected]
Fixes #DEV-395
Proposed changes