Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate unneeded utils, don't print enable/disable msg #60

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

primeapple
Copy link
Collaborator

@primeapple primeapple commented Oct 14, 2024

Why

Further cleanup of unneeded functions, as well as being more consistent in the README

Will wait for #51 (not needed anymore because of no breaking change)

To avoid a breaking change, I will deprecate the utils first. It can always be removed later.

@primeapple primeapple force-pushed the chore!-update-readme-and-remove-unneeded-utils branch from 0d7e526 to 0e9fac0 Compare October 14, 2024 13:34
@primeapple primeapple changed the title chore!: Remove unneeded utils and update README chore: Remove unneeded utils and update README Nov 8, 2024
@primeapple primeapple marked this pull request as ready for review November 8, 2024 21:22
@primeapple primeapple requested a review from okuuva November 8, 2024 21:23
@primeapple primeapple changed the title chore: Remove unneeded utils and update README chore: Deprecate unneeded utils, don't print enable/disable msg Nov 8, 2024
@okuuva
Copy link
Owner

okuuva commented Dec 4, 2024

Sorry @primeapple, I completely forgot this because I didn't immediately add it to my todo list -.-' I'll review it now.

Copy link
Owner

@okuuva okuuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of excess utils one by one warms my heart :)

@okuuva okuuva merged commit f8e3ac2 into main Dec 4, 2024
2 checks passed
@okuuva okuuva deleted the chore!-update-readme-and-remove-unneeded-utils branch December 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants