We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB3-DEX/contracts/8/DexRouter.sol
Line 397 in 556df81
function _smartSwapInternal( BaseRequest memory baseRequest, uint256[] memory batchesAmount, RouterPath[][] memory batches, address payer, address refundTo, address receiver ) private returns (uint256 returnAmount) { emit OrderRecord( fromToken, _baseRequest.toToken, tx.origin, --> _baseRequest.fromTokenAmount, returnAmount ); return returnAmount; }
Since OKX DEX support swapReceiverAddress, and the contract allows different receiver, it would be better if we can emit the receiver.
swapReceiverAddress
The text was updated successfully, but these errors were encountered:
yes, it make sense. we will consider add this in our next release.
Sorry, something went wrong.
good news!
This is an excellent suggestion. I fully endorse it and hope it gets considered. This feature would be very helpful for devs.
bixia
Successfully merging a pull request may close this issue.
WEB3-DEX/contracts/8/DexRouter.sol
Line 397 in 556df81
Since OKX DEX support
swapReceiverAddress
, and the contract allows different receiver, it would be better if we can emit the receiver.The text was updated successfully, but these errors were encountered: