Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For OrderRecord event 'receiver' is missing #7

Open
Umiiii opened this issue Jan 15, 2025 · 3 comments · May be fixed by #8
Open

For OrderRecord event 'receiver' is missing #7

Umiiii opened this issue Jan 15, 2025 · 3 comments · May be fixed by #8
Assignees
Labels
good first issue Good for newcomers

Comments

@Umiiii
Copy link

Umiiii commented Jan 15, 2025

emit OrderRecord(

    function _smartSwapInternal(
        BaseRequest memory baseRequest,
        uint256[] memory batchesAmount,
        RouterPath[][] memory batches,
        address payer,
        address refundTo,
        address receiver
    ) private returns (uint256 returnAmount) {
    
        emit OrderRecord(
            fromToken,
            _baseRequest.toToken,
            tx.origin,
 -->      
            _baseRequest.fromTokenAmount,
          returnAmount
        );
        return returnAmount;
    }

Since OKX DEX support swapReceiverAddress, and the contract allows different receiver, it would be better if we can emit the receiver.

@bixia
Copy link
Collaborator

bixia commented Jan 16, 2025

yes, it make sense. we will consider add this in our next release.

@clar
Copy link

clar commented Jan 16, 2025

good news!

@akira02
Copy link

akira02 commented Jan 16, 2025

This is an excellent suggestion. I fully endorse it and hope it gets considered.
This feature would be very helpful for devs.

@bixia bixia self-assigned this Jan 16, 2025
@bixia bixia added the good first issue Good for newcomers label Jan 16, 2025
@Umiiii Umiiii linked a pull request Jan 16, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants