add receiver address for OrderRecord event #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action parameters; update OrderRecord event emission for receiver address
bixia
requested changes
Jan 16, 2025
There was a problem hiding this comment.
we have 4 place to modify:
WEB3-DEX/contracts/8/DexRouter.sol
Line 397 in 556df81
WEB3-DEX/contracts/8/UnxswapRouter.sol
Line 503 in 556df81
WEB3-DEX/contracts/8/UnxswapV3Router.sol
Line 228 in 556df81
…outer; modify log entries in UnxswapRouter and UnxswapV3Router to reflect new event signature
bixia
requested changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the receiver address field to the OrderRecord event.
Why
Currently, when a swap occurs, an
OrderRecordevent is emitted. However, the event does not include thereceiveraddress, making it difficult to trace or verify the recipient of the swap. This addition ensures the event captures complete transaction details, improving transparency and debugging capabilities.Related Issue
Fixes #7
PR Checklist