Fast adding transaction to pool, without recover address from public key #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert some changes made in 0xPolygonHermez#1480
doutv
changed the title
zjg555543
reviewed
Jan 6, 2025
| toRemove = append(toRemove, slot.TxIds[idx]) | ||
| continue | ||
| } | ||
| // sender, err := signer.SenderWithContext(cryptoContext, transaction) |
There was a problem hiding this comment.
Seams in some case, the tx will error.
We can execute concurrently in advance, before the for loop and remote the tx, then it will have the same function and better safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert some changes made in 0xPolygonHermez#1480
Passkey + EOA, batch size 10, UOPS from 80 -> 130+
Waiting for Polygon's response, I comment in their PR