Merge pull request #116 from olcf/ngin_sig_verification

Signing issues should just throw a warning, not an exception

libpkpass/crypto.py

@@ -11,8 +11,7 @@
 from cryptography.hazmat.backends import default_backend
 from cryptography.hazmat.primitives import hashes
 from cryptography.hazmat.primitives.kdf.pbkdf2 import PBKDF2HMAC
-from libpkpass.errors import EncryptionError, DecryptionError, SignatureCreationError, \
-        SignatureVerificationError, X509CertificateError
+from libpkpass.errors import EncryptionError, DecryptionError, SignatureCreationError, X509CertificateError
 
 ##############################################################################
 def handle_python_strings(string):
@@ -130,9 +129,6 @@ def pk_verify_signature(string, signature, identity):
     proc = Popen(command, stdout=PIPE, stdin=PIPE, stderr=STDOUT)
     stdout, _ = proc.communicate(input=base64.urlsafe_b64decode(handle_python_strings(signature)))
 
-    if proc.returncode != 0:
-        raise SignatureVerificationError(stdout)
-
     return stdout.decode("ASCII") == stringhash
 
 

libpkpass/errors.py

@@ -77,9 +77,6 @@ class RSAKeyError(PKPassError):
 class SignatureCreationError(PKPassError):
     pass
 
-class SignatureVerificationError(PKPassError):
-    pass
-
 class TrustChainVerificationError(PKPassError):
     pass