This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Change jQuery loading method #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enqueues jQuery in WordPress insted of loading it with Webpack and makes the Webpacked Foundation scripts dependant on jQuery.
olefredrik
reviewed
Aug 12, 2017
library/enqueue-scripts.php
Outdated
| wp_deregister_script( 'jquery' ); | ||
|
|
||
| // CDN hosted jQuery placed in the header, as some plugins require that jQuery is loaded in the header. | ||
| wp_enqueue_script( 'jquery', 'https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array(), '2.10.2', false ); |
There was a problem hiding this comment.
I think versioning for this should reflect the jQuery version and not FoundationPress.
So this should be
wp_enqueue_script( 'jquery', 'https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js', array(), '3.2.1', false );
|
👍🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enqueues jQuery in WordPress insted of loading it with Webpack and makes
the Webpacked Foundation scripts dependant on jQuery.
Issue #1037