Fix cross-compilation #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
pass-target
branch
2 times, most recently
from
2433b77 to
695811a
Compare
|
Fixed the issues brought up in CI and added a comment to the implementation. |
I haven't created any cross compile tests yet. It'll probably be annoying to do, so don't worry about it |
|
Hmm... I think I'll need to add tests first. I worry this will interact badly with proc macro aux builds (which need to happen for the host) |
oli-obk
force-pushed
the
pass-target
branch
5 times, most recently
from
b53d94d to
ba9f2a6
Compare
jup it did interact badly 😆 fixed it now, but still can't get CI to actually work with cross compilation |
oli-obk
force-pushed
the
pass-target
branch
7 times, most recently
from
59ee6c4 to
4ea2280
Compare
|
Oh 🤷 I'm just not gonna test it in CI for now |
|
Cool, thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to cross-compile to
wasm32-unknown-unknown(for compilation fail tests only) I realized that the builder command was not actually taking the target into account: it was still building for the host target.Simply put, the builder command was just not taking
Config::targetinto account.Dependencies were already compiled to the correct target, but unfortunately I'm not familiar at all with
ui_testso there might be something else broken that I didn't try/encounter yet.Happy to add a test if pointed into the appropriate direction.