Support proc macro test dependencies #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be able to test this by adding serde_derive and using it in a |
bjorn3
force-pushed
the
fix_proc_macro_deps
branch
from
7888276 to
216298e
Compare
|
Done. Also fixed the formatting and added two commits to remove the diffs caused by automatic blessing of all tests. |
bjorn3
force-pushed
the
fix_proc_macro_deps
branch
from
216298e to
c08ec5f
Compare
|
Rebased |
This avoids test diffs when RUST_BACKTRACE=1 is set in in the shell config.
bjorn3
force-pushed
the
fix_proc_macro_deps
branch
from
c08ec5f to
4ca90a8
Compare
|
Removed an unnecessary change. I don't understand why the last CI run only failed on Windows: https://github.com/oli-obk/ui_test/actions/runs/8216901979/job/22472040330 |
I think that may be an orthogonal bug that just didn't surface before. Ralf reported it in miri recently |
|
It was two bugs! 😆 works locally on windows now. Let's see what CI says |
|
ah well, now I broke unixes 💀 |
oli-obk
force-pushed
the
fix_proc_macro_deps
branch
from
e5e33f1 to
dda7650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203