Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix For #4600 - Error When Only Frozen Columns Are Present and render Horizontal is Enabled #4601

Conversation

kunaljaykam
Copy link

@kunaljaykam kunaljaykam commented Oct 17, 2024

Fixes #4600

@kunaljaykam kunaljaykam force-pushed the fix-frozen-columns-renderHorizontal branch from d1402b5 to b99e284 Compare October 17, 2024 09:37
@olifolkerd
Copy link
Owner

Hey @kunaljaykam

Thanks for the PR, unfortunatly this fix reslved the issues by looking through all columns and calling the function. The whole point of the horizontal renderer is that it only does calculation on the columns visible in the view port, other wise it becomes very inefficient with large numbers of columns. but your idea can be easily replicated without the need to look at the whole tables worth of columns, so i will apply the appropriate patch in the next patch release.

Cheers

Oli :)

@olifolkerd olifolkerd closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error When Only Frozen Columns Are Present and renderHorizontal is Enabled
2 participants