Allow setup of port forwarder by passing custom PortForward struct #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow custom creation of PortForward structs while maintaining the rest of the useful creation code. Tied up tests.
|
Welcome @jcfvalente! It looks like this is your first PR to justinbarrick/go-k8s-portforward 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jcfvalente If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign justinbarrick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewPortForwarderCustom method should allow this. It's basically the same as NewPortForwarder, but by passing a pointer to a previously initialized PortForward struct.
Possible use case: when you know the name,namespace, destination port and listen port and just want to port-forward directly.
Under the current code, this is not possible, as either I would need to provide a labelSelector, which I don't need under this scenario, or I would have to construct everything by hand, having to import all sorts of packages to do it.
Also test updates, I suppose someone forgot to update the assertion strings and tests were failing.