Skip to content

Commit

Permalink
New: Setting to force black background and white blank page in night …
Browse files Browse the repository at this point in the history
…mode
  • Loading branch information
ollm committed May 14, 2024
1 parent 17e2e29 commit e7190f7
Show file tree
Hide file tree
Showing 26 changed files with 104 additions and 21 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

- Shortcut to go next/prev chapter [`9cda79e`](https://github.com/ollm/OpenComic/commit/9cda79e24dab1116c734e5a3773f74e13071c219)
- Option to rotate horizontal images [`20258ff`](https://github.com/ollm/OpenComic/commit/20258ff0ebf57d5a8064dec821ce745b7d9242a3)
- Setting to force black background and white blank page in night mode

##### 🐛 Bug Fixes

Expand Down
4 changes: 3 additions & 1 deletion languages/ca.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "Iniciar OpenComic a l'inici"
},
"theme": {
"systemNightMode": "Canviar al mode nit/clar quan el sistema operatiu ho faci"
"systemNightMode": "Canviar al mode nit/clar quan el sistema operatiu ho faci",
"nightModeBlackBackground": "Utilitzar el color negre com a fons en el mode nit",
"nightModeWhiteBlankPage": "Mostra les pàgines en blanc de color blanc en el mode nit"
},
"releases": {
"main": "Comprovar noves versions",
Expand Down
4 changes: 3 additions & 1 deletion languages/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "Start OpenComic on startup"
},
"theme": {
"systemNightMode": "Switch to night/light mode when the OS does it"
"systemNightMode": "Switch to night/light mode when the OS does it",
"nightModeBlackBackground": "Use black as background in night mode",
"nightModeWhiteBlankPage": "Show blank pages white in night mode"
},
"releases": {
"main": "Check for new versions",
Expand Down
4 changes: 3 additions & 1 deletion languages/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "Iniciar OpenComic al inicio"
},
"theme": {
"systemNightMode": "Cambiar al modo noche/claro cuando el sistema operativo lo haga"
"systemNightMode": "Cambiar al modo noche/claro cuando el sistema operativo lo haga",
"nightModeBlackBackground": "Utilizar el color negro como fondo en el modo noche",
"nightModeWhiteBlankPage": "Mostrar las páginas en blanco de color blanco en el modo noche"
},
"releases": {
"main": "Comprobar nuevas versiones",
Expand Down
4 changes: 3 additions & 1 deletion languages/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/hu.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "업데이트 확인",
Expand Down
4 changes: 3 additions & 1 deletion languages/pt-br.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
4 changes: 3 additions & 1 deletion languages/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "Starta OpenComic vid uppstart"
},
"theme": {
"systemNightMode": "Växla mellan nattläge och ljust läge när operativsystemet gör det"
"systemNightMode": "Växla mellan nattläge och ljust läge när operativsystemet gör det",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "Sök efter nya versioner",
Expand Down
4 changes: 3 additions & 1 deletion languages/th.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "เปิด OpenComic เมื่อเริ่มต้นระบบ"
},
"theme": {
"systemNightMode": "สลับโหมดกลางวัน/กลางคืนตามระบบ"
"systemNightMode": "สลับโหมดกลางวัน/กลางคืนตามระบบ",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "ตรวจหาเวอร์ชั่นใหม่",
Expand Down
4 changes: 3 additions & 1 deletion languages/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "Khởi động OpenComic khi bật máy"
},
"theme": {
"systemNightMode": "Chuyển sang chế độ sáng/tối theo hệ điều hành"
"systemNightMode": "Chuyển sang chế độ sáng/tối theo hệ điều hành",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "Kiểm tra phiên bản mới",
Expand Down
4 changes: 3 additions & 1 deletion languages/zh-hans.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": "开机启动时打开 OpenComic"
},
"theme": {
"systemNightMode": "当操作系统执行此操作时切换到夜间/明亮模式"
"systemNightMode": "当操作系统执行此操作时切换到夜间/明亮模式",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "检查新版本",
Expand Down
4 changes: 3 additions & 1 deletion languages/zh-hant.json
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@
"startOnStartup": ""
},
"theme": {
"systemNightMode": ""
"systemNightMode": "",
"nightModeBlackBackground": "",
"nightModeWhiteBlankPage": ""
},
"releases": {
"main": "",
Expand Down
18 changes: 18 additions & 0 deletions scripts/dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -1814,9 +1814,26 @@ function nightMode(force = null)
storage.updateVar('config', 'nightMode', true);
}

nightModeConfig(_app);

titleBar.setColors();
}

function nightModeConfig(_app = false)
{
_app = _app || document.querySelector('.app');

if(config.nightModeBlackBackground)
_app.classList.add('night-mode-black-background');
else
_app.classList.remove('night-mode-black-background');

if(config.nightModeWhiteBlankPage)
_app.classList.add('night-mode-white-blank-page');
else
_app.classList.remove('night-mode-white-blank-page');
}

// Show the comic context menu
async function comicContextMenu(path, fromIndex = true, fromIndexNotMasterFolders = true, folder = false, gamepad = false)
{
Expand Down Expand Up @@ -2269,6 +2286,7 @@ module.exports = {
goPrevComic: goPrevComic,
orderBy: orderBy,
nightMode: nightMode,
nightModeConfig: nightModeConfig,
addComicButtons: addComicButtons,
comicContextMenu: comicContextMenu,
removeComic: removeComic,
Expand Down
4 changes: 3 additions & 1 deletion scripts/storage.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var changes = 80; // Update this if readingPagesConfig is updated
var changes = 81; // Update this if readingPagesConfig is updated

var readingPagesConfig = {
readingConfigName: '',
Expand Down Expand Up @@ -79,6 +79,8 @@ var storageDefault = {
theme: 'material-design',
themeColor: 'blue',
nightMode: false,
nightModeBlackBackground: false,
nightModeWhiteBlankPage: false,
systemNightMode: false,
zoomFactor: 1,
foldersFirst: true,
Expand Down
4 changes: 2 additions & 2 deletions scripts/theme.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ function systemNightMode()

function start()
{
events.events();

if(!handlebarsContext.themeColors)
{
let themeColors = [];
Expand Down Expand Up @@ -93,6 +91,8 @@ function start()
template.loadContentRight('theme.content.right.html', true);

gamepad.updateBrowsableItems('theme');

events.events();
}

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion templates/body.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<span style="font-weight: 500;">Roboto</span>
<i class="material-icon">add</i>
</div>
<div class="app {{config.themeColor}}{{#if config.nightMode}} night-mode{{/if}}">
<div class="app {{config.themeColor}}{{#if config.nightMode}} night-mode{{/if}}{{#if config.nightModeBlackBackground}} night-mode-black-background{{/if}}{{#if config.nightModeWhiteBlankPage}} night-mode-white-blank-page{{/if}}">
<div class="title-bar"></div>
<div class="bar-header">

Expand Down
16 changes: 16 additions & 0 deletions templates/theme.content.right.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
<div class="settings-body body-medium">
<h1 class="display-medium">{{language.global.theme}}</h1>

<div class="menu-simple-text gamepad-item">
<span>{{language.settings.theme.nightModeBlackBackground}}</span>
<div class="switch{{#if config.nightModeBlackBackground}} a{{/if}}" on="settings.set('nightModeBlackBackground', true); dom.nightModeConfig();" off="settings.set('nightModeBlackBackground', false); dom.nightModeConfig();">
<div></div>
<svg viewBox="0 0 52 32"><path d="M 8,0 C 3.58,0 0,3.58 0,8 0,12.42 3.58,16 8,16 8,16 8,16 8,16 12.42,16 16,12.42 16,8 16,3.58 12.42,0 8,0 8,0 8,0 8,0 Z"></path></svg>
</div>
</div>

<div class="menu-simple-text gamepad-item">
<span>{{language.settings.theme.nightModeWhiteBlankPage}}</span>
<div class="switch{{#if config.nightModeWhiteBlankPage}} a{{/if}}" on="settings.set('nightModeWhiteBlankPage', true); dom.nightModeConfig();" off="settings.set('nightModeWhiteBlankPage', false); dom.nightModeConfig();">
<div></div>
<svg viewBox="0 0 52 32"><path d="M 8,0 C 3.58,0 0,3.58 0,8 0,12.42 3.58,16 8,16 8,16 8,16 8,16 12.42,16 16,12.42 16,8 16,3.58 12.42,0 8,0 8,0 8,0 8,0 Z"></path></svg>
</div>
</div>

<div class="theme-page">
{{#each themeColors}}

Expand Down
5 changes: 5 additions & 0 deletions themes/material-design/reading.css
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@
background-color: var(--md-sys-color-background);
}

.night-mode-white-blank-page .reading-body .r-img.blank > div > *, .night-mode-white-blank-page .reading-lens .r-img.blank > div > *
{
background-color: #fff;
}

.reading-body .r-img > oc-img, .reading-lens .r-img > oc-img
{
overflow: hidden;
Expand Down
1 change: 1 addition & 0 deletions themes/material-design/theme-page.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
justify-content: space-between;
padding-bottom: 60px;
padding: 0px 24px;
margin-top: 40px;
}

.theme-page-item
Expand Down
6 changes: 6 additions & 0 deletions themes/material-design/theme.css
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,12 @@ body .app
display: none;
}

body .app.night-mode.night-mode-black-background
{
--md-sys-color-background: #000;
--md-sys-color-surface: #000;
}

body .app > *
{
color: var(--md-sys-color-on-surface);
Expand Down

0 comments on commit e7190f7

Please sign in to comment.