Skip to content

Commit

Permalink
v5: Tweak some colors (twbs#31276)
Browse files Browse the repository at this point in the history
* Tweak green and cyan colors, bump min contrast ratio to 4.5

Co-authored-by: XhmikosR <[email protected]>
  • Loading branch information
2 people authored and olsza committed Oct 3, 2020
1 parent 82aced1 commit 57047d3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
8 changes: 4 additions & 4 deletions scss/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ $pink: #d63384 !default;
$red: #dc3545 !default;
$orange: #fd7e14 !default;
$yellow: #ffc107 !default;
$green: #28a745 !default;
$green: #198754 !default;
$teal: #20c997 !default;
$cyan: #17a2b8 !default;
$cyan: #0dcaf0 !default;

// scss-docs-start colors-map
$colors: (
Expand Down Expand Up @@ -87,10 +87,10 @@ $theme-color-interval: 8% !default;

// The contrast ratio to reach against white, to determine if color changes from "light" to "dark". Acceptable values for WCAG 2.0 are 3, 4.5 and 7.
// See https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast
$min-contrast-ratio: 3 !default;
$min-contrast-ratio: 4.5 !default;

// Customize the light and dark text colors for use in our color contrast function.
$color-contrast-dark: $gray-900 !default;
$color-contrast-dark: $black !default;
$color-contrast-light: $white !default;

// fusv-disable
Expand Down
7 changes: 7 additions & 0 deletions site/content/docs/5.0/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ toc: true
- Renamed `.sr-only` and `.sr-only-focusable` to `.visually-hidden` and `.visually-hidden-focusable`.
- Renamed `sr-only()` and `sr-only-focusable()` mixins to `visually-hidden()` and `visually-hidden-focusable()`.

### Colors

- Bumped color contrast ratio from 3:1 to 4.5:1.
- Set `$black` as color contrast color instead of `$gray-900`.
- Improved `$green` (and its theme alias `$success`) color to reach new minimum color contrast (moving from `#28a745` to `#198754`).
- Improved `$cyan` (and its theme alias `$info`) color to be more vibrant (moving from `#17a2b8` to `#0dcaf0`).

### Components

#### Buttons
Expand Down

0 comments on commit 57047d3

Please sign in to comment.