Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and improvements - 2 #10

Merged
merged 3 commits into from
Jul 2, 2019
Merged

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Jun 11, 2019

  • Fix an issue with DataManagerFacility.createDataset()
  • Add new method DataManagerFacility.changeGroup()

The issue with createDataset was: If you create a dataset and add it to a project within the same call and then do the same again with another dataset but without reloading the project in between, then the first dataset gets unlinked from the project again.

Integration tests: ome/openmicroscopy#6048

@rgozim
Copy link
Member

rgozim commented Jun 18, 2019

It took a while to get the integration tests running on my system, but yea, everything seems to work fine.

@dominikl
Copy link
Member Author

Maybe we just scrap the integration tests... they're definitely a big pain now to run with the separated repositories!

@rgozim
Copy link
Member

rgozim commented Jun 18, 2019

Try this out when you get a chance - ome/openmicroscopy#6060

Makes running and using the integration tests much easier.

Procedure I did, was:

  • checked out your branch (this one)
  • ran gradle publishToMavenLocal
  • changed omero.properties versions.omero-gateway in openmicroscoy project to be 5.5.3-SNAPSHOT
  • ran ./build.py build in openmicroscopy directory
  • imported OmeroJava as a gradle project in intellj
  • started local omero server
  • ran your tests :)

@joshmoore
Copy link
Member

Maybe we just scrap the integration tests...

😱 🙉

We will soon face the same issue with the python integration tests. Probably worth some thought into what will make this easier.

@joshmoore
Copy link
Member

Merging for 5.5.3. Plan is to get integration tests green before releasing.

@joshmoore joshmoore merged commit 9589287 into ome:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants