Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IJ plugin open image when using websocket #106

Merged
merged 1 commit into from
Jan 23, 2020
Merged

IJ plugin open image when using websocket #106

merged 1 commit into from
Jan 23, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Jan 22, 2020

Fix issue preventing to open images using B-F when using the imagej plugin

To test:

  • Download the omero_ij jar
  • connect to a server with ws enable e.g. workshop or outreach
  • Open an image in ImageJ
  • The image should open
    cc @pwalczysko @dominikl

@dominikl
Copy link
Member

Thanks @jburel . I thought I changed the getHostname() call everywhere back then, but missed that one apparently. I'll give it a try later.

@dominikl
Copy link
Member

Could reproduce the error with released version 5.5.8. Works with 5.5.9-Snapshot from merge-ci. Good to merge 👍

@jburel jburel merged commit 876ec52 into ome:master Jan 23, 2020
@jburel jburel deleted the ij_plugin branch July 1, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jburel @dominikl