Bin importer #127
Bin importer #127
Conversation
| @Override | ||
| void execute(CreateStartScripts css) { | ||
| css.mainClassName = InsightBasePlugin.MAIN_INSIGHT | ||
| css.mainClassName = InsightBasePlugin.MAIN_INSIGHT+" containerImporter.xml" |
There was a problem hiding this comment.
@jburel : I don't understand this change. Why is the XML file being added to mainClassName?
There was a problem hiding this comment.
I can't find a way in CreateStartScripts to pass argument.
The mainClassName is then added to a bash command: JVMARG mainClassName etc.
An other option could be to do bin/omero-importer containerImporterXml
but I opted to have the same approach that the one for insight
There was a problem hiding this comment.
another option could be to add another main class but this one, which is probably not the most elegant, is the less intrusive and requires the less changes. Extending the gradle plugin will be the best option but it will require major work
This is very low priority
There was a problem hiding this comment.
Understood. Let's go with it, keeping in mind that it's confusing and probably brittle.
There was a problem hiding this comment.
I will add a TODO. The option might be added to the gradle plugin in the future
|
👍 Works fine, both for Insight and Importer. |
This fixes the issue described in #25
To test locally
gradle buildbin/omero-importeror download the OMERO.importer from daily build and unzip