-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug; Lookupname for omero home dir was overwritten #156
Conversation
If it's not too urgent to merge, I'll add a test which checks uniqueness of the LookupNames to prevent this in future. |
This is great, @dominikl . With the passing test, I'm inclined to get this in (and released). I can't overly speak to the removed fields though in terms of breakingness. (If you have any concerns, any option would be to deprecate them instead) |
True, I added them again as deprecated. Intellij flagged them up as unused, but I'll check again properly and remove them after the next release. |
Testing the functionality. Try to repeat the problems: Mac OS, release insight 5
Mac OS, insight 5.5.11 release.
Note: I am also not sure which script did the users run, but possibly the problem they were hitting was the subsequent inability to download the resulting file (attachment to the image on which the script was run). I am repeating the failure of downloading (any) attachment from insight in Ad 1. above. |
So insight 5.5.11 is failing to download any attachments, with the error reported in #156 (comment) - I think this upgrades significantly the seriousness of the issue here... |
Tested the insight from merge-ci. All problems reported in #156 (comment) are fixed. |
Releasing as 5.5.13 |
The
USER_MDE_PATH
LookupName conflicted with theUSER_HOME_OMERO
one, which caused issues #154 and #153.Test:
See travis builds of last two commits to check that the units test works.
Check that Insight still works as expected.
And check that Insight now picks up the correct location for its files again, e.g. the log file, see #153 .