Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDE enabled in the standard configuration of importer #229

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

sukunis
Copy link
Member

@sukunis sukunis commented Jun 7, 2021

For easier use of the OMERO.mde also for users who download the OMERO.insight as an exe . Default location for a mdeConfiguration file is the local user omero directory.

…cation of mdeConfiguration file to local user omero directory
@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-insight-push#816. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-insight-push#816. See the console output for more details.
Possible conflicts:

  • Upstream changes
    • src/config/container.xml
    • src/config/containerImporter.xml

--conflicts

@joshmoore
Copy link
Member

Just to add a little context, with the mde paper in preparation, it would be good to make accessing the extension easier. If anyone has issues with its stability or presence in the UI, let's try to find a solution that doesn't require users (or system administrators) to hand edit an XML file.

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-insight-push#818. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Jun 18, 2021

Conflicting PR. Removed from build OMERO-insight-push#818. See the console output for more details.
Possible conflicts:

  • Upstream changes
    • src/config/container.xml
    • src/config/containerImporter.xml

--conflicts Conflict resolved in build OMERO-insight-push#831. See the console output for more details.

# Conflicts:
#	src/config/container.xml
#	src/config/containerImporter.xml
@jburel
Copy link
Member

jburel commented Jun 30, 2021

Tested with build https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/822/
MDE is turned on by default, no impact on the import functionality
Imported using both non mde and mde option

@jburel jburel merged commit ba3e5d0 into ome:master Jun 30, 2021
@sbesson
Copy link
Member

sbesson commented Jul 1, 2021

@sukunis thanks for all your work on this project. We are in the process of rolling out a Contributor License Agreement for all external contributions to the OME repositories. Instructions are available here. Could you fill out the form and send it back to us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants