use toURI method to handle

[jburel]

This should fix issue with file path.
see https://www.openmicroscopy.org/qa2/qa/feedback/30780/ and #237
cc @dominikl

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-insight-push#1011. See the console output for more details.
Possible conflicts:

• PR path error #216 jburel 'path error'
  • src/main/java/org/openmicroscopy/shoola/util/ui/filechooser/GenericFileChooser.java

--conflicts Conflict resolved in build OMERO-insight-push#1012. See the console output for more details.

[dominikl]

Ah interesting, that might fix a few other similar issues too. I'll review later.

[dominikl]

Tested with a build from the PR branch. Looks good, doesn't break anything. I don't know how to replicate the issue though.

[jburel]

Did you try on Windows 10? since this is the OS which seems to trigger the problem
cc @pwalczysko

[dominikl]

Yes, Windows 10 and imported from local as well as network share, both works, with and without the PR.

[dominikl]

This PR now also Fixes #111 .

To replicate that error: Open import dialog. In the drop down select "This PC". Insight crashes with InvalidPathException. Has to be tested on Windows 10.

Test: Check that Insight doesn't crash with this PR.

[pwalczysko]

How to start an insight https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/ on windows ?

[pwalczysko]

I can confirm the crash with release insight when I select in importer the "Computer" folder on Windows (maxquant).
The crash throws

java.lang.Exception: Abnormal termination due to an uncaught exception.
java.nio.file.InvalidPathException: Illegal char <:> at index 52: C:\Users\pwalczysko\AppData\Local\OMERO.insight\app\::{20D04FE0-3AEA-1069-A2D8-08002B30309D}
	at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
	at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
...

This crash is fiexed by the presenet PR.

[pwalczysko]

Import seems to work normally on Windows with this PR.

I am tempted to say that is all we can do in terms of testing here, as the original error #237 workflow is not described. It definitely does not just happen because on Windows, the app works more or less normally.

cc @jburel ?

[jburel]

See also https://www.openmicroscopy.org/qa2/qa/feedback/30868/

[jburel]

@pwalczysko any objection if I merge this PR, I would like to include it in a point release

[pwalczysko]

@pwalczysko any objection if I merge this PR, I would like to include it in a point release

Good to merge fmpov