Enable pointing to external container xml #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instructions should be added to the FAQ indicating how to use external config file |
jburel
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363 .
You can start Insight with a positional argument pointing to the container xml (e.g. container.xml for the "normal" Insight, containerImport.xml for the Importer). In the OSX build this argument is set by OMERO.insight.cfg:
Without this PR the container xml has to be in the config directory within the bundle. With this PR you can point to any location. If the argument contains at least one path character it is assumed it specifies a file outside the bundle, if it doesn't (i.e. it's only a file name) it's assumed that it specifies a file within config directory of the bundle.
The PR also removes the code to enable the DebugRepaintManager, as it's actually not used any more.