Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fat jar #72

Merged
merged 5 commits into from
Aug 28, 2019
Merged

fat jar #72

merged 5 commits into from
Aug 28, 2019

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 27, 2019

This PR replaces #68

  • It creates a fat jar (due to time limit config will be included in jar in another PR)
  • The OMERO.imagej now contains the fat jar instead to the jar and lib. This has been an issue for many users
  • Allows to use the plugin in Fiji

cc @pwalczysko

@pwalczysko
Copy link
Member

Locally built (gradle clean build) insight-ij from this branch (built on Mac and transferred to Win7 machine or used on that Mac:

Tested on Win7, workflow
- connect, open an image, crop image, import to OMERO,
- open an image, draw ROI, create measurements in Fiji, save ROI and measurements to OMERO
- in Fiji only, tested "Open with" -> opened images in Win7 app called "Paint"
tested in

  • legacy Fiji 2017
  • newly downloaded and upgraded Fiji
  • ImageJ

Tested on Mac (workflow: connect and open an image)
tested in

  • Fiji
  • ImageJ

All tests were successful

@pwalczysko
Copy link
Member

Retested again with the latest commit on Win7

  • Fiji
  • ImageJ

All good

@jburel
Copy link
Member Author

jburel commented Aug 28, 2019

Thanks

@jburel jburel merged commit d1e5bd5 into ome:master Aug 28, 2019
@jburel jburel deleted the fix/fiji branch July 1, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants