Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build #17

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Build #17

merged 6 commits into from
Dec 16, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 21, 2024

Update actions and Update PyPI publish workflow to use build instead of sdist

@jburel jburel closed this Nov 21, 2024
@jburel jburel reopened this Nov 21, 2024
@will-moore
Copy link
Member

Build is failing with:

________________ ERROR collecting test/integration/test_ngff.py ________________
ImportError while importing test module '/omero-web-zarr/test/integration/test_ngff.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/integration/test_ngff.py:29: in <module>
    from ome_zarr.reader import Reader
E   ModuleNotFoundError: No module named 'ome_zarr'

Can't see what's going on here. It is possible to install ome_zarr on Python 3.9 and it installs zarr 2.18.3. ome_zarr is not required for regular installation but it is listed under test requirements at

tests_require=['pytest', 'ome_zarr'],

@will-moore will-moore mentioned this pull request Nov 25, 2024
@jburel
Copy link
Member Author

jburel commented Dec 14, 2024

@will-moore build is now green with 95ff08b

@jburel jburel requested a review from will-moore December 14, 2024 20:19
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: 👍

@jburel jburel merged commit 8f3c313 into ome:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants