Robot fix xpath to dialog button

[will-moore]

The buttons in the jQuery UI dialog seems to have been changed by some jQuery UI issue, which
causes a lot of tests to fail.

I previously saw this on my old laptop where tests failed (without this PR change) but it has been passing on the CI job until recently.

[will-moore]

Today with this fix, we have only 19 failing tests https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/203/ instead of 62 yesterday https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/202/. Will look at the remaining failures...

[will-moore]

https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/209/ Doesn't have any "robot results". @sbesson any ideas? Just re-run again?

[will-moore]

Ooops - my bad (above). Robot tests are running again, but failing with E.g.

ValueError: Element locator 'xpath=//div[contains(@class,'ui-dialog')][contains(@style,'display: block')]//button/span[contains(text(), 'OK')]' did not match any elements.

which suggests that this PR is not included. @sbesson Any ideas what's up here?

[sbesson]

@will-moore: looking at the job console log it looks like the job is failing when populating the data for the tests:

05:52:03 + python lib/python/omero/util/populate_metadata.py -k 02f36117-55e8-4bb8-99de-748c6ec0cdee Plate:261 bulk_annotation.csv
05:52:03 Traceback (most recent call last):
05:52:03   File "lib/python/omero/util/populate_metadata.py", line 33, in <module>
05:52:03     import omero.clients
05:52:03 ImportError: No module named omero.clients

[will-moore]

@sbesson Sorry - yes, I just found that.
I was confused because the page at https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/ links to Robot Results from a few days ago.

The problem is caused by #4446.
I previously had a line to set the $PYTHONPATH but removed it because it was failing
will-moore@562e88f
and now it's failing to import.
Any idea how I can get dist/lib/python onto the PYTHONPATH?

[will-moore]

We are back to a small number of Robot tests failing: https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/217/robot/ so I think this is working now.

[will-moore]

The whole reason for the failure of Robot tests on the dialog buttons was webtagging React PR adding in Bootstrap.button(), which created dialog buttons without the extra span element.

[will-moore]

Only 1 failure now, so things are looking good: https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/221/robot/

[atarkowska]

Test are green https://ci.openmicroscopy.org/view/DEV/job/OMERO-DEV-merge-robotframework/224/robot/

[atarkowska]

Looks good to me. Test are passing two days in a raw. Good to merge

[jburel]

Waiting an extra day, but certainly looks much better

[jburel]

https://ci.openmicroscopy.org/view/OMERO-DEV/job/OMERO-DEV-merge-robotframework/ is green
merging