-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ingest folder #25
Feature/ingest folder #25
Conversation
The pr is based on previous one because it fixes the same issue, but it can be separated if needed. |
The people who create items one by one at our library are not usually very tech savy. On Omeka Classic, they used to select all the documents from one repertory to upload them and that was it. This was essential when dealing with documents of hundreds of pages. |
I'm currently reviewing this. Please rebase your branch so the changes I merged upstream are updated and don't show up in this PR. |
ca7c24f
to
f124233
Compare
Yes, it's rebased. |
2e29c6c
to
8ccd9b9
Compare
I'm wary of the use of "folder" throughout your changes (even the new name). We already use "directory" in this module and others, so I prefer that you change "folder" to "directory." |
I renamed "folder" by "directory" in last commit. |
9d8497c
to
6c7c27e
Compare
I notice that the "Directory" select menu does not include the sideload directory itself. Is there a reason for this? |
Thank you for this important feature! |
Sometime users want to import some hundreds files for one item, for example all images of a scanned manuscript, so to select the directory is a lot simpler.