Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ingest folder #25

Merged
merged 12 commits into from
Jan 28, 2022

Conversation

Daniel-KM
Copy link
Contributor

Sometime users want to import some hundreds files for one item, for example all images of a scanned manuscript, so to select the directory is a lot simpler.

@Daniel-KM
Copy link
Contributor Author

The pr is based on previous one because it fixes the same issue, but it can be separated if needed.

@AlyxTaj
Copy link

AlyxTaj commented Oct 12, 2021

The people who create items one by one at our library are not usually very tech savy. On Omeka Classic, they used to select all the documents from one repertory to upload them and that was it. This was essential when dealing with documents of hundreds of pages.
Now that we're moving to Omeka S, the bulk upload of files is going to be missing, and I cannot imagine them creating a CSV file with the list of media to link to an item they have created.
This folder based option to FileUpload would be an amazing improvement for us.

@jimsafley
Copy link
Contributor

I'm currently reviewing this. Please rebase your branch so the changes I merged upstream are updated and don't show up in this PR.

@Daniel-KM Daniel-KM force-pushed the feature/ingest_folder branch from ca7c24f to f124233 Compare October 19, 2021 06:43
@Daniel-KM
Copy link
Contributor Author

Yes, it's rebased.

Module.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Outdated Show resolved Hide resolved
src/Media/Ingester/SideloadDir.php Show resolved Hide resolved
@Daniel-KM Daniel-KM force-pushed the feature/ingest_folder branch from 2e29c6c to 8ccd9b9 Compare October 20, 2021 17:12
@jimsafley
Copy link
Contributor

I'm wary of the use of "folder" throughout your changes (even the new name). We already use "directory" in this module and others, so I prefer that you change "folder" to "directory."

@Daniel-KM
Copy link
Contributor Author

I renamed "folder" by "directory" in last commit.

@Daniel-KM Daniel-KM force-pushed the feature/ingest_folder branch from 9d8497c to 6c7c27e Compare January 8, 2022 10:17
@jimsafley
Copy link
Contributor

I notice that the "Directory" select menu does not include the sideload directory itself. Is there a reason for this?

config/module.ini Outdated Show resolved Hide resolved
@jimsafley jimsafley merged commit baf5f16 into omeka-s-modules:master Jan 28, 2022
@jimsafley
Copy link
Contributor

Thank you for this important feature!

@Daniel-KM Daniel-KM deleted the feature/ingest_folder branch February 10, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants