Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to CollectionsController show method #936

Open
timstallmann opened this issue Feb 22, 2021 · 1 comment
Open

Add pagination to CollectionsController show method #936

timstallmann opened this issue Feb 22, 2021 · 1 comment

Comments

@timstallmann
Copy link
Contributor

We're developing a theme where we'd like to show all collection items (paginated) via the collections/show route rather than via items/browse. It strikes me as strange that the show method on the collections controller doesn't currently set any of the correct variables for pagination to work -- happy to work on a PR to add this functionality in, but was there some reasoning there that I should know about?

@zerocrates
Copy link
Member

I don't think there's any grand reasoning behind there not being the option of pagination here, other than simply that it's a "show" page, and pagination is typically reserved for the browse pages.

My only real concern would be that this doesn't interfere with directing people to the "real" full browse, at least in default themes.

timstallmann pushed a commit to timstallmann/Omeka that referenced this issue Mar 15, 2021
timstallmann pushed a commit to timstallmann/Omeka that referenced this issue Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants