-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource template required fields #2041
Comments
This is due to an errant "value" class in the URI data type's markup (here). We need to remove the class, but it affects the styling. @kimisgold Would you take a look at this? We need to replace that "value" class. |
Edited the class to be more specific to the input. It's ready to test @allanaaa |
The code attempts to do what I think is expected here: it just uses the label. The problem is that the non-custom label is there in the markup, hidden, so the code here is finding both the original and the alternate label. Something simple like calling |
You should now only get one label, @allanaaa |
Just to make sure, do the whole "clear cache" thing: this was a Javascript-only fix so if you're looking at the old Javascript you'd still see it. |
The basic deal is, value markup needs to have a Both are a little oddball in that they involve having several inputs each of which is optional. ValueSuggest may be able to get by marking the main visible input as to-require but I suspect something more complex may be required for NumericDataTypes (or maybe just requiring the "first" input will be sufficient there). This would be an issue for each module, anyway. |
(cherry picked from commit 240aef6)
(cherry picked from commit 7c5e3b1)
I have a resource template with several required fields.
When I apply the template to an existing item, then try to save, I get an error about the first required field that stops me from moving on. I don't get an error about the other field(s), in this case the creator field.
When I put in a description and save, it will save the new description value, give me an error about the creator, and fail to save the template change.
What I'd like instead is for the creator (and any other required fields) error to work the same way as the description error does, and stop me from moving on until I fill everything out. I presume this is "We only show one error, the first we come across, and then don't do any more checks after that" rather than "We only check a few particular properties when they are required", which would be odd.
The text was updated successfully, but these errors were encountered: