Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item stubs #2216

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
38f48a6
Begin implementing resource stub
jimsafley Jul 9, 2024
e9c5850
Continue dev
jimsafley Jul 9, 2024
e7db625
Continue dev
jimsafley Jul 10, 2024
e40a196
Continue dev
jimsafley Jul 11, 2024
6950b81
Continue dev
jimsafley Jul 11, 2024
0d8995e
Continue dev
jimsafley Jul 12, 2024
057d345
Continue dev
jimsafley Jul 13, 2024
99f0eda
Continue dev
jimsafley Jul 15, 2024
664ac71
Continue dev
jimsafley Jul 15, 2024
0da03d1
Continue dev
jimsafley Jul 16, 2024
f4b4f28
Continue dev
jimsafley Jul 16, 2024
3e73aad
Begin converting to template-based item stub form
jimsafley Jul 18, 2024
7aa38a8
Continue dev
jimsafley Jul 19, 2024
d71c1c2
Continue dev
jimsafley Jul 20, 2024
6423db5
Begin implementing resource stub
jimsafley Jul 9, 2024
e827180
Continue dev
jimsafley Jul 9, 2024
3d9655c
Continue dev
jimsafley Jul 10, 2024
1273963
Continue dev
jimsafley Jul 11, 2024
6ae3386
Continue dev
jimsafley Jul 11, 2024
15f10f5
Continue dev
jimsafley Jul 12, 2024
79109ab
Continue dev
jimsafley Jul 13, 2024
4167a55
Continue dev
jimsafley Jul 15, 2024
45c742e
Continue dev
jimsafley Jul 15, 2024
b7d415a
Continue dev
jimsafley Jul 16, 2024
feeb9d8
Continue dev
jimsafley Jul 16, 2024
43b7280
Begin converting to template-based item stub form
jimsafley Jul 18, 2024
1b61b17
Continue dev
jimsafley Jul 19, 2024
e2ef051
Continue dev
jimsafley Jul 20, 2024
3882a8b
Merge branch 'item-stub' of github.com:omeka/omeka-s into item-stub
jimsafley Jul 20, 2024
4e7a5e1
Continue dev
jimsafley Jul 20, 2024
e459987
Continue dev
jimsafley Jul 21, 2024
8d6eb27
Continue dev
jimsafley Jul 22, 2024
316c1d2
Continue dev
jimsafley Jul 23, 2024
bfc19a5
Continue dev
jimsafley Jul 23, 2024
8f731e1
Continue dev
jimsafley Jul 23, 2024
121ef5d
Continue dev
jimsafley Jul 24, 2024
76dba50
Continue dev
jimsafley Jul 24, 2024
74d38ba
Continue dev
jimsafley Jul 24, 2024
33356f8
Continue dev
jimsafley Jul 24, 2024
3a26c0b
Continue dev
jimsafley Jul 24, 2024
ebf7f0f
Style required tag for value annotation values.
kimisgold Jul 24, 2024
fbd903b
Style sidebar tabs.
kimisgold Jul 24, 2024
de1c6be
Add heading to item stub form for consistency.
kimisgold Jul 24, 2024
febc3c2
Ensure value annotation value inputs use full sidebar width.
kimisgold Jul 24, 2024
1123698
Continue dev
jimsafley Jul 24, 2024
6c4e7fe
Adjust sidebar tabs for new div container markup.
kimisgold Jul 25, 2024
1e88223
Continue dev
jimsafley Jul 25, 2024
599060a
Continue dev
jimsafley Jul 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Continue dev
jimsafley committed Jul 16, 2024

Verified

This commit was signed with the committer’s verified signature.
Emojigit 1F616EMO~nya
commit f4b4f28cc7f6e3cbece2f55e4d6b1e73f5b5fbfd
2 changes: 1 addition & 1 deletion application/asset/js/resource-form.js
Original file line number Diff line number Diff line change
@@ -427,7 +427,7 @@
const propertyValue = $(this);
if (propertyValue.val()) {
const propertyId = propertyValue.data('propertyId');
const type = propertyValue.data('type');
const type = propertyValue.data('type') ?? 'literal';
if (!itemData.hasOwnProperty(propertyId)) {
itemData[propertyId] = [];
}
7 changes: 4 additions & 3 deletions application/src/Form/ItemStubForm.php
Original file line number Diff line number Diff line change
@@ -86,7 +86,6 @@ public function init()
'attributes' => [
'id' => 'item-stub-title',
'data-property-id' => $property->id(),
'data-type' => 'literal',
'data-property-id-default' => $property->id(),
'data-property-label-default' => $translate('Title'),
],
@@ -105,7 +104,6 @@ public function init()
'attributes' => [
'id' => 'item-stub-description',
'data-property-id' => $property->id(),
'data-type' => 'literal',
'data-property-id-default' => $property->id(),
'data-property-label-default' => $translate('Description'),
],
@@ -120,7 +118,10 @@ public function init()
],
]);

// Allow modules to modify this form.
// Allow modules to modify this form. Modules may add value elements by
// adding a "data-property-id" attribute to the element, set to the
// property ID. They may also add a "data-type" attribute to the element
// to set a data type that is not "literal".
$addEvent = new Event('form.add_elements', $this);
$this->getEventManager()->triggerEvent($addEvent);