Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify spec details in KHR_audio and add property summary tables #199

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Jan 4, 2024

Several aspects of the spec were not clear before. Changes:

  • Add property summary tables for all properties.
  • Specify default values.
  • Add details on the cone angle, specify this is an angular diameter and not a radius (this matches Web Audio).
  • Add note that a max distance of 0 should be treated as an infinite max distance.
  • Remove limitation of max distance only being available on linear, allow it for all.
  • Update the cone diagram to be clearer.

Copy link
Contributor

@antpb antpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the meeting and after my review, everything looks good and has no errors from my review.

@lyuma lyuma merged commit ff3fbc0 into omigroup:main Jan 4, 2024
1 check passed
aaronfranke added a commit to aaronfranke/glTF that referenced this pull request Jan 4, 2024
aaronfranke added a commit to aaronfranke/glTF that referenced this pull request Jan 4, 2024
aaronfranke added a commit to aaronfranke/glTF that referenced this pull request Jan 4, 2024
aaronfranke added a commit to aaronfranke/glTF that referenced this pull request Jan 5, 2024
aaronfranke added a commit to aaronfranke/glTF that referenced this pull request Jan 11, 2024
@aaronfranke aaronfranke deleted the KHR_audio_tweaks branch January 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants