Add safe-execute button in ALM #580
Conversation
I think there might be some rare situations, in which message should be recorded as failed. However, it is not possible to commit failed messages when using automatic gas limit, so it will be possible to do so only via old executeSignatures method. Therefore I kept both buttons, do you think it might be a valid use-case? |
May you suggest formal criteria how to decide whether the message must be recorded as failed? I would introduce a check box near to the button and output these criteria when a user moves the cursor above the check box. If the check box is chosen |
|
Do you think such UI would be appropriate? |
| checked={allowFailures} | ||
| onChange={e => setAllowFailures(e.target.checked)} | ||
| /> | ||
| <label htmlFor="allow-failures">Allow Failures</label> |
There was a problem hiding this comment.
Does it make sense to call it "Unsafe execution" as so only users which understand what it means consider to use it?
There was a problem hiding this comment.
Ok, we might do so. I have renamed it to "Unsafe mode".
This merge contains the following set of changes: * [Monitor, Improvement] Add statistics about used AMB information requests (#577) * [ALM, Improvement] Add safe-execute button in ALM (#580), closes #573, closes #551 * [Oracle, Improvement] Improve confirm-relay feature (#582), closes #569 * [Monitor, Fix] Prune print of long error messages about missing file (#579), closes #578 * [Oracle, Fix] Use safe approach for eth_getLogs requests (#581) * [Oracle, Fix] Fix logging in gas price service (#583), closes #552 * [Oracle, Fix] Fix oracle error patterns and oracle e2e tests (#585) * [Common, Other] Fix dependencies versions and update example.yml (#566) * [Common, Other] Upload services logs in e2e and ultimate tests (#568) * [Oracle, Other] added example of emergency shutdown controller contract (#572) * [Oracle, Other] Refactor oracle configuration (#584)
Closes #573
Closes #551