-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create main.tf #11
base: master
Are you sure you want to change the base?
Create main.tf #11
Conversation
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. For this repo, Jit automatically implements this security plan:
All security workflows are defined in a centralized repository named .jit. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
🚀 env0 had composed a PR Plan for environment First Integration attempts / ASDF-46559:
Failure Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Jit has detected 2 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.
bucket = var.bucket_name | ||
acl = "public" | ||
|
||
versioning { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type: S3 Bucket Without Enabled Mfa Delete
Description: S3 bucket without MFA Delete Enabled. MFA delete cannot be enabled through Terraform, it can be done by adding a MFA device (https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_mfa_enable.html) and enabling versioning and MFA delete by using AWS CLI: 'aws s3api put-bucket-versioning --versioning-configuration=Status=Enabled,MFADelete=Enabled --bucket=<BUCKET_NAME> --mfa=<MFA_SERIAL_NUMBER>'
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_finding
Ignore this specific single instance of finding#jit_ignore_type_this_repo
Ignore any finding of this type in this repo#jit_undo_ignore
Undo ignore command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#jit_ignore_finding
}) | ||
} | ||
|
||
resource "aws_s3_bucket" "this" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type: S3 Bucket Sse Disabled
Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required
Jit Bot commands and options (e.g., ignore issue)
You can trigger Jit actions by commenting on this PR review:
#jit_ignore_finding
Ignore this specific single instance of finding#jit_ignore_type_this_repo
Ignore any finding of this type in this repo#jit_undo_ignore
Undo ignore command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#jit_ignore_finding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Great news! All security issues were resolved. Good Job! 🏆
test |
Testing comments for Atlantis |
env0 list |
Could not find any aliases |
env0 help |
|
env0 plan -e null_template1 |
Environment aliases null_template1 don't exist. Please refine your command. |
Testing Jit