Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create main.tf #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create main.tf #11

wants to merge 3 commits into from

Conversation

omry-hay
Copy link
Owner

Testing Jit

@jit-ci
Copy link

jit-ci bot commented Dec 28, 2021

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

For this repo, Jit automatically implements this security plan:

Plan item What have we already done? Active
Scanning Python repos for vulnerabilities Integrated Code Scanner, which is triggered for every new PR in Python repos
Scanning for hard-coded passwords Integrated Secret Scanner, which is triggered for every new PR in any repository

All security workflows are defined in a centralized repository named .jit.
In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@env0-dev
Copy link

env0-dev bot commented Dec 28, 2021

🚀  env0 had composed a PR Plan for environment First Integration attempts / ASDF-46559:

Plan Failed
Failure Details
Secret references are only supported in self-hosted agents.

Full Plan Logs on env0

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 2 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.

bucket = var.bucket_name
acl = "public"

versioning {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type: S3 Bucket Without Enabled Mfa Delete

Description: S3 bucket without MFA Delete Enabled. MFA delete cannot be enabled through Terraform, it can be done by adding a MFA device (https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_mfa_enable.html) and enabling versioning and MFA delete by using AWS CLI: 'aws s3api put-bucket-versioning --versioning-configuration=Status=Enabled,MFADelete=Enabled --bucket=<BUCKET_NAME> --mfa=<MFA_SERIAL_NUMBER>'

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_ignore_type_this_repo Ignore any finding of this type in this repo
  • #jit_undo_ignore Undo ignore command

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#jit_ignore_finding

})
}

resource "aws_s3_bucket" "this" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type: S3 Bucket Sse Disabled

Description: If algorithm is AES256 then the master key is null, empty or undefined, otherwise the master key is required

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_ignore_type_this_repo Ignore any finding of this type in this repo
  • #jit_undo_ignore Undo ignore command

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#jit_ignore_finding

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! All security issues were resolved. Good Job! 🏆

@omry-hay
Copy link
Owner Author

test

@omry-hay
Copy link
Owner Author

Testing comments for Atlantis

@omry-hay
Copy link
Owner Author

env0 list

@env0-dev
Copy link

env0-dev bot commented Mar 13, 2022

Could not find any aliases

@omry-hay
Copy link
Owner Author

env0 help

@env0-dev
Copy link

env0-dev bot commented Mar 13, 2022

  1. ℹ️ env0 help - lists all available commands
  2. 🔢 env0 list - returns a list of all available environments in env0.
  3. 🔂 env0 plan -e {environments aliases} - runs a plan on the env0 environments aliases. Aliases can be comma separated if you like to run more than one environment.
  4. ⏯️ env0 apply -e {environments aliases} - runs apply on the env0 environments aliases. Aliases can be comma separated if you like to run more than one environment.

@omry-hay
Copy link
Owner Author

env0 plan -e null_template1

@env0-dev
Copy link

env0-dev bot commented Mar 13, 2022

Environment aliases null_template1 don't exist. Please refine your command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants