[FEATURE] introducing wave info to expansion #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: on3iro#467 Phase 1: - Add wave attribute to Expansion/IExpansion data/type - Display wave in Settings -> Expansions - Display expansion/wave language dependent in Randomizer -> Supply - Display expansion/wave language dependent in card details
Issue: on3iro#467 Fix Phase 1: - fix cypress test due to bigger supply card display (caused by wave)
|
@MilanTheHawk Hi, thanks for submitting this PR and sorry for my late response. Unfortunately I am super busy right now and do not yet have time to look into this. But I'll try to catch up asap! :) |
on3iro
approved these changes
Mar 13, 2023
|
|
||
| function formatExpansionName(expansion: types.Expansion): string { | ||
| return expansion.wave | ||
| ? expansion.name + ' (' + expansion.wave + ')' |
There was a problem hiding this comment.
@MilanTheHawk I would prefer a template literal here:
`${expansion.name} (${expansion.wave})`But no need to change this. We can refactor this, when we stumble over it in the future ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #467
Phase 1: