-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values for estate lists #491
Comments
@fredericalpers so the "country" field is not working properly. |
@fredericalpers bandicam_2023-04-11_15-18-07-101.mp4pls, check and give me your opinion on this issue? |
@dai-eastgate The number input should only be if applicable, for instance purchase price or rooms. Otherwise it should be a normal input field so text can be added. |
@fredericalpers this one more, please check it. Thanks |
Please go ahead and fix it. If possible in a different issue so that it is more distinguishable and clear, whats being worked on. |
I will fix it for estate list at this issue when add new default values. |
@fredericalpers I have implemented "Make default values available in estate lists, the same as in forms" feature. |
@dai-eastgate I have one more question. The field "preventAutomaticPortalResponse" is a single-select in WP backend but in the frontend its displayed as a radio button group? In my opionion it should be displayed as a single-select in the frontend too. Please go ahead and try to fix this. Other than that it seems good to me! We will test it on our end when you guys fixed the above mentioned issue. Thank you. |
Yes, I will check it again, thanks |
@fredericalpers
|
Sorry for the confusion! We finally had the chance to talk about the problem at hand and came to the conclusion that: Checkbox in onOffice enterprise = Checkbox in WP Backend and also displayed as a Checkbox in Frontend. |
@fredericalpers I fixed it, please take a look at the video below. bandicam.2023-04-27.15-44-08-464.mp4 |
I'm afraid there was a misunderstanding. We do not want radio buttons, instead we want a checkbox, which means not checked = Not specified / no and if it is checked = yes. As you can see in the screenshot below, in onOffice enterprise the "preventAutomaticPortalResponse" field is a checkbox. I do not know why there even is a value for "not specified" if it's only supposed to be a toggle for "yes" and "no". Also please note the definitions: https://www.w3schools.com/tags/att_input_type_radio.asp and https://www.w3schools.com/tags/att_input_type_checkbox.asp |
Let me check again and let you know soon. |
@fredericalpers
If we fix as you like "instead we want a checkbox, which means not checked = Not specified / no and if it is checked = yes." You can see in the video bandicam.2023-04-27.19-06-04-122.mp4 |
@dai-eastgate after a long discussions with my colleagues we came to the conclusion that we wan't to keep the radio buttons with all 3 values. Thank you for your patience. |
May you can help me, I think I miss some settings for my test environment and can not test this issue... :( So I get following errors in frontend: And Backend: |
@andernath Let me check again and let you know soon |
@andernath The reason may be that you have not copied the "DefaultValueEstateModelToOutputConverter" class to the source code. |
@dai-eastgate I guess I need to use a deployed zip for this branch like from this workflow: https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/workflows/development-zip.yml but before approving pull request. |
@andernath Maybe because when you copy files manually. PHP-DI No entry or class found for 'interface name'. |
@dai-eastgate Unfortunately our testing raised some more issues, which we will have to investigate further to give you our feedback. This however will have to be postponed until after my vacation on 2023-05-22. Thank you :) |
@onOffice-Web Yes, I will check again when receive your feedback. At that time, I will focus on other issues in this cycle. Thank you and have a nice vacation! |
Hello @dai-eastgate,
On the other hand the boolean field sauna works well and filter estates correctly. There is another issue we still need to clarify internally. If changes are necessary here, we will contact you after next tuesday. |
Hi @andernath
|
Hi @andernath For these issues, do you want me to implement it during this ramp-up week or to do it in the next cycles? |
@fredericalpers I have finished investigating this issue, please reopen PRs #494 or let me open the PRs so I can fix it |
@dai-eastgate I reopened the PR #494 :) |
@fredericalpers When reading an estate for fields with "type=boolean", the API responses results returned "4 type values" as case 3: The return => Please confirm for my following comments: But, now I checked the API does not support when I pass val = 'null' in the operator Question 2: Please check with the IT department and confirm the above issues so we can clear the requirement and then give you the exact solution and plan for this issue. Thanks! |
(1) Im assuming Case 2 "Null" is when the field is added to the fieldlist in the WP Backend but not checked in enterprise. (2) As for (empty string) I'm assuming this is caused only by "Preis auf Anfrage" since this is changing the actual price value into a text? (3) "Not specified" is needed in the search for when this field is not used by the customer visiting the website. The search criteria is not included when filtering. Example: Terrasse = No " Only properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed. Terrasse = Not specified = All properties will be displayed, regardless of whether the "Terrasse" Boolean is checked or not in onOffice enterprise. |
=> Yes, you are correct. |
=> No, you got it wrong. |
=> OK, I got it. I still keep the "Not specified" option in the "filter feature". |
This is my understanding:
|
@fredericalpers I have implemented on the branch 32986-default-values-for-estate-lists with the condition that when filter 'No', it will display values as 0(No) or "" (empty string), but for Null values, I cannot handle them currently because the API does not support it. You can also try testing it on this branch. |
yes, exactly! :) |
@fredericalpers Please check with the IT department about this issue. |
|
@dai-eastgate I sent a ticket to the IT department and will give you feedback as soon as possible :) |
As of now filtering for "NULL" is not possible. This however has to be fixed in onOffice enterprise, therefore this feature unfortunately has to be postponed indefinetly. |
@fredericalpers I got it, thanks! |
Closed until further notice. |
Discussed in #441
Originally posted by fredericalpers February 7, 2023
Current state
For forms, it is possible to set a default value. For example, marketing type "Purchase". Unfortunately, it is not possible to set this for property lists which are used to generate the property search module as shown here: https://wp-plugin-demo.onoffice.com/de/immobilien/immobilienliste/
Therefore we can not choose a default value for above mentioned property search module.
Current standard value = "Please select"
Desired state
The text was updated successfully, but these errors were encountered: