Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for estate lists #491

Closed
fredericalpers opened this issue Apr 6, 2023 Discussed in #441 · 59 comments
Closed

Default values for estate lists #491

fredericalpers opened this issue Apr 6, 2023 Discussed in #441 · 59 comments
Assignees
Labels
blocked Blocked due to external factors

Comments

@fredericalpers
Copy link
Member

Discussed in #441

Originally posted by fredericalpers February 7, 2023

Current state

For forms, it is possible to set a default value. For example, marketing type "Purchase". Unfortunately, it is not possible to set this for property lists which are used to generate the property search module as shown here: https://wp-plugin-demo.onoffice.com/de/immobilien/immobilienliste/

Therefore we can not choose a default value for above mentioned property search module.

Current standard value = "Please select"

Desired state

  • Make default values available in estate lists, the same as in forms so the standard value can easily be changed to e.g. "Rent" or "Purchase"

default_values_forms-1
no_default_values_estatelist

@dai-eastgate
Copy link
Contributor

@fredericalpers
Field "country" has been renamed to "land".
but It didn't edited in this line of code
image

so the "country" field is not working properly.
Do I need to fix it?

@dai-eastgate
Copy link
Contributor

@fredericalpers
In the Form, when we add new the field to the "filter-fields-list".
"Default Value" of all fields have type="number" input
This video

bandicam_2023-04-11_15-18-07-101.mp4

pls, check and give me your opinion on this issue?
Default values for "estate lists" will implement same Default values "form"?

@fredericalpers
Copy link
Member Author

@fredericalpers In the Form, when we add new the field to the "filter-fields-list". "Default Value" of all fields have type="number" input This video

pls, check and give me your opinion on this issue? Default values for "estate lists" will implement same Default values "form"?

@dai-eastgate The number input should only be if applicable, for instance purchase price or rooms. Otherwise it should be a normal input field so text can be added.

@dai-eastgate
Copy link
Contributor

@fredericalpers Field "country" has been renamed to "land". but It didn't edited in this line of code image

so the "country" field is not working properly. Do I need to fix it?

@fredericalpers this one more, please check it. Thanks

@fredericalpers
Copy link
Member Author

@fredericalpers Field "country" has been renamed to "land". but It didn't edited in this line of code image

so the "country" field is not working properly. Do I need to fix it?

Please go ahead and fix it. If possible in a different issue so that it is more distinguishable and clear, whats being worked on.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 12, 2023

@fredericalpers In the Form, when we add new the field to the "filter-fields-list". "Default Value" of all fields have type="number" input This video
pls, check and give me your opinion on this issue? Default values for "estate lists" will implement same Default values "form"?

@dai-eastgate The number input should only be if applicable, for instance purchase price or rooms. Otherwise it should be a normal input field so text can be added.

I will fix it for estate list at this issue when add new default values.
For the "form" part I will create another issue. thanks

@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented "Make default values available in estate lists, the same as in forms" feature.
Pls check and give me your opinion?
This demo video
https://files.fm/u/frsebj64f

@fredericalpers
Copy link
Member Author

@fredericalpers I have implemented "Make default values available in estate lists, the same as in forms" feature. Pls check and give me your opinion? This demo video https://files.fm/u/frsebj64f

@dai-eastgate I have one more question. The field "preventAutomaticPortalResponse" is a single-select in WP backend but in the frontend its displayed as a radio button group? In my opionion it should be displayed as a single-select in the frontend too. Please go ahead and try to fix this.

Other than that it seems good to me! We will test it on our end when you guys fixed the above mentioned issue. Thank you.

@yennt89
Copy link
Contributor

yennt89 commented Apr 21, 2023

Yes, I will check it again, thanks

@yeneastgate
Copy link
Contributor

yeneastgate commented Apr 24, 2023

@fredericalpers
I checked the "preventAutomaticPortalResponse" field.
This field has the "Boolean" type.
On master branch, This field show in frontend same image
image

  1. Please confirm, Do you want to convert only "preventAutomaticPortalResponse" field in frontend to "single-select" same in WP backend?

  2. Or Do you want to convert to "single-select" in the frontend for all field which has "Boolean" type?

@fredericalpers
Copy link
Member Author

@fredericalpers I checked the "preventAutomaticPortalResponse" field. This field has the "Boolean" type. On master branch, This field show in frontend same image image

  1. Please confirm, Do you want to convert only "preventAutomaticPortalResponse" field in frontend to "single-select" same in WP backend?
  2. Or Do you want to convert to "single-select" in the frontend for all field which has "Boolean" type?

Sorry for the confusion! We finally had the chance to talk about the problem at hand and came to the conclusion that:

Checkbox in onOffice enterprise = Checkbox in WP Backend and also displayed as a Checkbox in Frontend.
e. g. "preventAutomaticPortalResponse" is a Checkbox in enterprise so it should be a Checkbox in WP Backend and Frontend.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 27, 2023

@fredericalpers I fixed it, please take a look at the video below.

bandicam.2023-04-27.15-44-08-464.mp4

@fredericalpers
Copy link
Member Author

@fredericalpers I fixed it, please take a look at the video below.

bandicam.2023-04-27.15-44-08-464.mp4

I'm afraid there was a misunderstanding. We do not want radio buttons, instead we want a checkbox, which means not checked = Not specified / no and if it is checked = yes. As you can see in the screenshot below, in onOffice enterprise the "preventAutomaticPortalResponse" field is a checkbox. I do not know why there even is a value for "not specified" if it's only supposed to be a toggle for "yes" and "no".

Also please note the definitions: https://www.w3schools.com/tags/att_input_type_radio.asp and https://www.w3schools.com/tags/att_input_type_checkbox.asp

checkbox-enterprise

@dai-eastgate
Copy link
Contributor

Let me check again and let you know soon.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Apr 27, 2023

@fredericalpers
We can fix it to "checkbox" but will have the problem happen:

  1. Backward compatible
    Currently in the "field.php" file, All field has "boolean" type will show radio buttons.
    image
  2. "Search filter" feature
    Ex: "Public" field.
    "Not specified" option : we can show all 12 results.
    "Yes" option : we can show 3 results
    "No" option : we can show 9 results

If we fix as you like "instead we want a checkbox, which means not checked = Not specified / no and if it is checked = yes."
then the search result will be wrong

You can see in the video
Please give me your opinion on this matter? thanks

bandicam.2023-04-27.19-06-04-122.mp4

@fredericalpers
Copy link
Member Author

@dai-eastgate after a long discussions with my colleagues we came to the conclusion that we wan't to keep the radio buttons with all 3 values. Thank you for your patience.

@andernath
Copy link
Contributor

andernath commented May 3, 2023

May you can help me, I think I miss some settings for my test environment and can not test this issue... :(
I installed current plugin version 4.10.1 and updated folders: plugin, css and js with your changes in branch "32986 Default values for estate lists".
But honestly I don't know how to update the vendor folder, which is not part of the git repo.

So I get following errors in frontend:
[onOffice-Plugin] Ein Fehler ist aufgetreten: DI\NotFoundException: No entry or class found for 'onOffice\WPlugin\Field\DefaultValue\ModelToOutputConverter\DefaultValueEstateModelToOutputConverter' in /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/vendor/php-di/php-di/src/Container.php:136 Stack trace: #0 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/EstateList.php(603): DI\Container->get('onOffice\\WPlugi...') #1 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/EstateList.php(575): onOffice\WPlugin\EstateList->getDefaultValues() #2 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/EstateList.php(873): onOffice\WPlugin\EstateList->getFieldValue('kaufpreis') #3 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-personalized/templates/estate/SearchForm.php(21): onOffice\WPlugin\EstateList->getVisibleFilterableFields() #4 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-personalized/templates/estate/default.php(29): require('/www/htdocs/w01...') #5 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Template.php(118): include('/www/htdocs/w01...') #6 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Template.php(82): onOffice\WPlugin\Template::getIncludeContents(NULL, '/www/htdocs/w01...', NULL) #7 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Controller/ContentFilter/ContentFilterShortCodeEstateList.php(137): onOffice\WPlugin\Template->render() #8 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Controller/ContentFilter/ContentFilterShortCodeEstate.php(94): onOffice\WPlugin\Controller\ContentFilter\ContentFilterShortCodeEstateList->render(Array) #9 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Controller/ContentFilter/ContentFilterShortCodeEstate.php(69): onOffice\WPlugin\Controller\ContentFilter\ContentFilterShortCodeEstate->buildReplacementString(Array) #10 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Controller/ContentFilter/ContentFilterShortCodeRegistrator.php(59): onOffice\WPlugin\Controller\ContentFilter\ContentFilterShortCodeEstate->replaceShortCodes(Array) #11 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/shortcodes.php(355): onOffice\WPlugin\Controller\ContentFilter\ContentFilterShortCodeRegistrator->onOffice\WPlugin\Controller\ContentFilter\{closure}(Array, '', 'oo_estate') #12 [internal function]: do_shortcode_tag(Array) #13 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/shortcodes.php(227): preg_replace_callback('/\\[(\\[?)(oo_est...', 'do_shortcode_ta...', '[oo_estate view...') #14 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/class-wp-hook.php(308): do_shortcode('[oo_estate view...') #15 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/plugin.php(205): WP_Hook->apply_filters('[oo_estate view...', Array) #16 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/post-template.php(255): apply_filters('the_content', '<!-- wp:shortco...') #17 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/themes/neve/inc/views/page_layout.php(29): the_content() #18 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/class-wp-hook.php(308): Neve\Views\Page_Layout->render_page('') #19 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters('', Array) #20 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #21 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/themes/neve/template-parts/content-page.php(9): do_action('neve_do_single_...') #22 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/template.php(785): require('/www/htdocs/w01...') #23 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/template.php(718): load_template('/www/htdocs/w01...', false, Array) #24 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/general-template.php(204): locate_template(Array, true, false, Array) #25 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/themes/neve/page.php(47): get_template_part('template-parts/...', 'page') #26 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-includes/template-loader.php(106): include('/www/htdocs/w01...') #27 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-blog-header.php(19): require_once('/www/htdocs/w01...') #28 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/index.php(17): require('/www/htdocs/w01...') #29 {main}

And Backend:
Fatal error: Uncaught DI\NotFoundException: No entry or class found for 'onOffice\WPlugin\Model\InputModelBuilder\InputModelBuilderDefaultValueEstate' in /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/vendor/php-di/php-di/src/Container.php:136 Stack trace: #0 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Model/FormModelBuilder/FormModelBuilderDBEstateListSettings.php(770): DI\Container->get('onOffice\\WPlugi...') #1 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Model/FormModelBuilder/FormModelBuilderDBEstateListSettings.php(366): onOffice\WPlugin\Model\FormModelBuilder\FormModelBuilderDBEstateListSettings->getInputModelDefaultValue(Object(onOffice\WPlugin\Types\FieldsCollection)) #2 /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/plugin/Gui/AdminPageSettingsBase.php(492): onOffice\WPlugin\Model\FormMode in /www/htdocs/w01bee5f/w3pm.onofficeweb.com/htdocs/wp-content/plugins/onoffice-for-wp-websites-32986/vendor/php-di/php-di/src/Container.php on line 136

@dai-eastgate
Copy link
Contributor

@andernath Let me check again and let you know soon

@dai-eastgate
Copy link
Contributor

dai-eastgate commented May 4, 2023

@andernath The reason may be that you have not copied the "DefaultValueEstateModelToOutputConverter" class to the source code.
Please double check the existence of the class or you can take a video so I can understand better.

@andernath
Copy link
Contributor

@dai-eastgate
I have checked it several times: I copy and paste all (except for the tests) commited files form Branch 32986 (https://github.com/onOffice-Web-Org/oo-wp-plugin/pull/494/files) to my test environment manually with FTP.

I guess I need to use a deployed zip for this branch like from this workflow: https://github.com/onOffice-Web-Org/oo-wp-plugin/actions/workflows/development-zip.yml but before approving pull request.

@dai-eastgate
Copy link
Contributor

@andernath Maybe because when you copy files manually. PHP-DI No entry or class found for 'interface name'.
Please try "composer dump-autoload" command. Hope it will work!

@onOffice-Web
Copy link
Collaborator

@dai-eastgate Unfortunately our testing raised some more issues, which we will have to investigate further to give you our feedback. This however will have to be postponed until after my vacation on 2023-05-22. Thank you :)

@dai-eastgate
Copy link
Contributor

@onOffice-Web Yes, I will check again when receive your feedback. At that time, I will focus on other issues in this cycle. Thank you and have a nice vacation!

@andernath
Copy link
Contributor

andernath commented May 25, 2023

Hello @dai-eastgate,
sorry for late answer, I finished testing now.

  1. I have one suggestion for improvement:
    It would be useful to be able to enter a default value only if the field is filterable. Similar to "hidden". See: "filter on.png and filter off.png

filter on
filter off

  1. I also found one bugs:
    For some booleans (for example: field "terrasse" (in "Ausstattung") and field "provisionsfrei" (in "Preise")) the number of filtered estates is not correct in my opinion.
    I have 14 estates, one of them has a terrace, the others do not.
    If the filter is set to "No specification": I get 14 results. (Correct!)
    If the filter is set to "Yes": I get 1 result. (Correct!)
    If the filter is set to "No": I get 0 results. (Wrong, I expect 13)

On the other hand the boolean field sauna works well and filter estates correctly.

There is another issue we still need to clarify internally. If changes are necessary here, we will contact you after next tuesday.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented May 25, 2023

Hello @dai-eastgate, sorry for late answer, I finished testing now.

  1. I have one suggestion for improvement:
    It would be useful to be able to enter a default value only if the field is filterable. Similar to "hidden". See: "filter on.png and filter off.png

filter on filter off

  1. I also found one bugs:
    For some booleans (for example: field "terrasse" (in "Ausstattung") and field "provisionsfrei" (in "Preise")) the number of filtered estates is not correct in my opinion.
    I have 14 estates, one of them has a terrace, the others do not.
    If the filter is set to "No specification": I get 14 results. (Correct!)
    If the filter is set to "Yes": I get 1 result. (Correct!)
    If the filter is set to "No": I get 0 results. (Wrong, I expect 13)

On the other hand the boolean field sauna works well and filter estates correctly.

There is another issue we still need to clarify internally. If changes are necessary here, we will contact you after next tuesday.

Hi @andernath

  1. I will check and implement it.
  2. I will check and fix it.
    Thanks.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented May 26, 2023

Hi @andernath For these issues, do you want me to implement it during this ramp-up week or to do it in the next cycles?

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 4, 2023

@fredericalpers I have finished investigating this issue, please reopen PRs #494 or let me open the PRs so I can fix it

@fredericalpers
Copy link
Member Author

@dai-eastgate I reopened the PR #494 :)

@fredericalpers fredericalpers linked a pull request Oct 4, 2023 that will close this issue
@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 6, 2023

@fredericalpers
After retesting the "filter feature" for fields with "type=boolean", I found the following problems:

When reading an estate for fields with "type=boolean", the API responses results returned "4 type values" as 0 (no), 1(yes), null, OR "" (empty string)
ex: "filter feature" for field "terrasse" and "preisAufAnfrage"
case 1: The return value = 0 (no) OR 1(yes)
image
case 2: The return value = null (when we create a new estate on the enterprise and uncheck the checkbox)
https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/b5a15379-5e8a-4405-ad20-cd891726ecc1

case 3: The return value = ""(empty string) (when we create a new estate on the enterprise and fields with "type=boolean" which is deactivated in onOffice enterprise)
https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/bfa320ce-445b-4c9f-99f9-c4252e8c5f27

=> Please confirm for my following comments:
When we use the "filter feature" in the front-end of the "Estate list":
Question 1:
What is "option select"(No specified, Yes, No) will check with "filter feature"?
image
=> Estates that we are filtering with "type=boolean" return "value = null" (watch demo case 2 above) will display.

But, now I checked the API does not support when I pass val = 'null' in the operator $fieldFilter []= ['op' => '=', 'val' => 'null'];

Question 2:
What is "option select"(No specified, Yes, No) will check with "filter feature"?
image
=> Estates that we are filtering with type=boolean return value = "" (watch demo case 3 above) will display.

Please check with the IT department and confirm the above issues so we can clear the requirement and then give you the exact solution and plan for this issue. Thanks!

@fredericalpers
Copy link
Member Author

@dai-eastgate

(1) Im assuming Case 2 "Null" is when the field is added to the fieldlist in the WP Backend but not checked in enterprise.

(2) As for (empty string) I'm assuming this is caused only by "Preis auf Anfrage" since this is changing the actual price value into a text?

(3) "Not specified" is needed in the search for when this field is not used by the customer visiting the website. The search criteria is not included when filtering.

Example:
Terrasse = Yes = Only properties which have "Terrasse" Boolean checked in onOffice enterprise will be displayed.

Terrasse = No " Only properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed.

Terrasse = Not specified = All properties will be displayed, regardless of whether the "Terrasse" Boolean is checked or not in onOffice enterprise.

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 6, 2023

(1) Im assuming Case 2 "Null" is when the field is added to the fieldlist in the WP Backend but not checked in enterprise.

=> Yes, you are correct.
However: currently the api does not support "NULL" value, even if I pass the filter as ["op" => "=", "val" => null], the estate API will only response to estates with field "NULL".

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 6, 2023

(2) As for (empty string) I'm assuming this is caused only by "Preis auf Anfrage" since this is changing the actual price value into a text?

=> No, you got it wrong.
This is because the "price on request" field has been deactivated in onOffice enterprise (please review case 3 above). You can see the image after I deactivated field "provisionsfrei" in onOffice enterprise.

image

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 6, 2023

(3) "Not specified" is needed in the search for when this field is not used by the customer visiting the website. The search criteria is not included when filtering.

=> OK, I got it. I still keep the "Not specified" option in the "filter feature".

@dai-eastgate
Copy link
Contributor

dai-eastgate commented Oct 6, 2023

Example: Terrasse = Yes = Only properties which have "Terrasse" Boolean checked in onOffice enterprise will be displayed.

Terrasse = No " Only properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed.

Terrasse = Not specified = All properties will be displayed, regardless of whether the "Terrasse" Boolean is checked or not in onOffice enterprise.

This is my understanding:

  • Terrasse = yes has 10 properties checked on the enterprise system
    => Only 10 properties which have "Terrasse" Boolean checked in onOffice enterprise will be displayed.
  • Terrasse = No has 5 properties not checked on the enterprise system
    => Only 5 properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed.
  • Terrasse = Not specified = (Terrasse = yes has 10 )+ (Terrasse = No has 5) right?

@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented on the branch 32986-default-values-for-estate-lists with the condition that when filter 'No', it will display values as 0(No) or "" (empty string), but for Null values, I cannot handle them currently because the API does not support it. You can also try testing it on this branch.

@fredericalpers
Copy link
Member Author

Example: Terrasse = Yes = Only properties which have "Terrasse" Boolean checked in onOffice enterprise will be displayed.
Terrasse = No " Only properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed.
Terrasse = Not specified = All properties will be displayed, regardless of whether the "Terrasse" Boolean is checked or not in onOffice enterprise.

This is my understanding:

  • Terrasse = yes has 10 properties checked on the enterprise system
    => Only 10 properties which have "Terrasse" Boolean checked in onOffice enterprise will be displayed.
  • Terrasse = No has 5 properties not checked on the enterprise system
    => Only 5 properties which have "Terrasse" Boolean NOT checked in onOffice enterprise will be displayed.
  • Terrasse = Not specified = (Terrasse = yes has 10 )+ (Terrasse = No has 5) right?

yes, exactly! :)

@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented on the branch 32986-default-values-for-estate-lists with the condition that when filter 'No', it will display values as 0(No) or "" (empty string), but for Null values, I cannot handle them currently because the API does not support it. You can also try testing it on this branch.

image

@fredericalpers Please check with the IT department about this issue.

@dai-eastgate
Copy link
Contributor

@fredericalpers

  1. I tried building a "filter expression" on the enterprise system with the following syntax:
    ObjAusstattung.wintergarten != '1' OR ObjAusstattung.wintergarten IS NULL
    The filter results work exactly as in the "Desired state"
    https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/dd2f54b6-0f65-4d3d-9948-bfb599733354
    => "NULL" values are working properly for the "IS" SQL operators
    as the same API Document
    image

  2. I tried to implement the above syntax to pass on the "filter parameter", but the filter results do not work as the "Desired state"
    https://github.com/onOffice-Web-Org/oo-wp-plugin/assets/106214469/7441b174-a71c-466b-838a-66fb9ff2ee13
    => Please check with the IT department and let me know exactly about "NULL" values for "IS" SQL operators

@fredericalpers
Copy link
Member Author

fredericalpers commented Oct 12, 2023

@dai-eastgate I sent a ticket to the IT department and will give you feedback as soon as possible :)

@fredericalpers fredericalpers added the up for discussion Issues and Pull Requests which will be discussed label Oct 17, 2023
@fredericalpers fredericalpers modified the milestones: v4.17, v4.18 Oct 18, 2023
@fredericalpers fredericalpers added blocked Blocked due to external factors and removed up for discussion Issues and Pull Requests which will be discussed labels Oct 25, 2023
@fredericalpers fredericalpers removed this from the v4.18 milestone Oct 25, 2023
@dai-eastgate dai-eastgate self-assigned this Oct 31, 2023
@fredericalpers
Copy link
Member Author

fredericalpers commented Nov 16, 2023

As of now filtering for "NULL" is not possible. This however has to be fixed in onOffice enterprise, therefore this feature unfortunately has to be postponed indefinetly.

@dai-eastgate
Copy link
Contributor

As of now filtering for "NULL" is not possible. This however has to be fixed in onOffice enterprise, therefore this feature unfortunately has to be postponed indefinetly.

@fredericalpers I got it, thanks!

@fredericalpers
Copy link
Member Author

Closed until further notice.

#491 (comment)

@fredericalpers fredericalpers closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked due to external factors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants