Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable build #19

Merged
merged 25 commits into from
Mar 16, 2021
Merged

Conversation

peterMuriuki
Copy link
Collaborator

  • Make steps used to build the app configurable.
  • Add scenario where this scripts target opensrp-web, reveal

@moshthepitt
Copy link
Contributor

Add scenario where this scripts target opensrp-web, reveal

What differences necessitate this?

@peterMuriuki
Copy link
Collaborator Author

peterMuriuki commented Mar 16, 2021

Add scenario where this scripts target opensrp-web, reveal

What differences necessitate this?

@moshthepitt the only difference is in the build steps i.e.:
reveal only requires the build command, while opensrp web: might require transpiling the packages + building the app.
scnearios, meant to demonstrate the configurable build process.

  • arguably, the opensrp-web scenario would suffice

@peterMuriuki
Copy link
Collaborator Author

@KipSigei the commented out section is intentional, shows the full structure of the react_build_cmds variable

@peterMuriuki peterMuriuki merged commit 44152e0 into opensrp-web-deployment-tweaks Mar 16, 2021
@peterMuriuki peterMuriuki deleted the configurableBuild branch March 16, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants