Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date range picker on the plan form #1291

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

peterMuriuki
Copy link
Collaborator

@peterMuriuki peterMuriuki commented Nov 15, 2023

Disable dates in the past. This means

  • start date can only be current date or a future date.
  • end date can only be start date or future date.
  • Removed table stripping styling.

@machariamuguku
Copy link
Member

@peterMuriuki could you attach a screenshot? Especially on the styling

@peterMuriuki
Copy link
Collaborator Author

@machariamuguku
Screenshot from 2023-11-16 10-18-14
Screenshot from 2023-11-16 10-18-50

@machariamuguku
Copy link
Member

@peterMuriuki LGTM but there seems to be test failing. Idk if it's related

@peterMuriuki
Copy link
Collaborator Author

@peterMuriuki LGTM but there seems to be test failing. Idk if it's related

Yeap they are some flaky tests, this test fail is not related to any changes made in this pr.

@peterMuriuki peterMuriuki merged commit f93c447 into opensrp-1 Nov 16, 2023
1 of 2 checks passed
@peterMuriuki peterMuriuki deleted the 1290-date-plans branch November 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants