Merge pull request #967 from onaio/change-id-type-to-int

Change tableau id type to int
onaio · Mar 24, 2017 · daf3355 · daf3355
2 parents 910e6c2 + 364efc7
commit daf3355
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/onadata/apps/api/tests/viewsets/test_open_data_viewset.py b/onadata/apps/api/tests/viewsets/test_open_data_viewset.py
@@ -222,6 +222,12 @@ def test_column_headers_endpoint(self):
             response.data.get('table_alias')
         )
 
+        _id_datatype = [
+            a.get('dataType')
+            for a in response.data['column_headers']
+            if a.get('id') == '_id'][0]
+        self.assertEqual(_id_datatype, 'int')
+
     def test_uuid_endpoint(self):
         self.view = OpenDataViewSet.as_view({
             'get': 'uuid'

diff --git a/onadata/apps/api/viewsets/open_data_viewset.py b/onadata/apps/api/viewsets/open_data_viewset.py
@@ -93,7 +93,10 @@ def append_to_tableau_colulmn_headers(header, question_type=None):
                     append_to_tableau_colulmn_headers(header, quest_type)
                     break
             else:
-                append_to_tableau_colulmn_headers(header)
+                if header == '_id':
+                    append_to_tableau_colulmn_headers(header, "int")
+                else:
+                    append_to_tableau_colulmn_headers(header)
 
         return tableau_colulmn_headers